Skip to content

Commit 38e46fb

Browse files
committed
Merge branch '2022.2' into 2022.3
2 parents 025f546 + 9303a12 commit 38e46fb

File tree

57 files changed

+741
-299
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

57 files changed

+741
-299
lines changed

gradle.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ kotlin.code.style=official
1414
ideaVersion = 2022.3
1515
ideaVersionName = 2022.3
1616

17-
coreVersion = 1.6.3
17+
coreVersion = 1.6.4
1818
downloadIdeaSources = true
1919

2020
pluginTomlVersion = 223.7571.59

readme.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ Minecraft Development for IntelliJ
3131
</tr>
3232
</table>
3333

34-
Info and Documentation [![Current Release](https://img.shields.io/badge/release-1.6.3-orange.svg?style=flat-square)](https://plugins.jetbrains.com/plugin/8327)
34+
Info and Documentation [![Current Release](https://img.shields.io/badge/release-1.6.4-orange.svg?style=flat-square)](https://plugins.jetbrains.com/plugin/8327)
3535
----------------------
3636

3737
<a href="https://discord.gg/j6UNcfr"><img src="https://i.imgur.com/JXu9C1G.png" height="48px"></img></a>

src/gradle-tooling-extension/groovy/com/demonwav/mcdev/platform/mcp/gradle/tooling/fabricloom/FabricLoomModelBuilderImpl.groovy

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,8 +52,15 @@ class FabricLoomModelBuilderImpl implements ModelBuilderService {
5252
decompilers << ["single": getDecompilers(loomExtension, false)]
5353
}
5454

55+
def modSourceSets = [:]
56+
57+
for (def mod in loomExtension.getMods()) {
58+
def modName = mod.getName()
59+
modSourceSets[modName] = mod.getModSourceSets().getOrNull()?.collect { it.sourceSet().getName() }
60+
}
61+
5562
//noinspection GroovyAssignabilityCheck
56-
return new FabricLoomModelImpl(tinyMappings, decompilers, splitMinecraftJar)
63+
return new FabricLoomModelImpl(tinyMappings, decompilers, splitMinecraftJar, modSourceSets)
5764
}
5865

5966
List<FabricLoomModelImpl.DecompilerModelImpl> getDecompilers(Object loomExtension, boolean client) {
@@ -73,7 +80,7 @@ class FabricLoomModelBuilderImpl implements ModelBuilderService {
7380
}
7481

7582
//noinspection GroovyAssignabilityCheck
76-
return new FabricLoomModelImpl(tinyMappings, ["single": decompilers], false)
83+
return new FabricLoomModelImpl(tinyMappings, ["single": decompilers], false, [:])
7784
}
7885

7986
@Override

src/gradle-tooling-extension/groovy/com/demonwav/mcdev/platform/mcp/gradle/tooling/fabricloom/FabricLoomModelImpl.groovy

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ class FabricLoomModelImpl implements FabricLoomModel, Serializable {
1717
File tinyMappings
1818
Map<String, List<DecompilerModel>> decompilers
1919
boolean splitMinecraftJar
20+
Map<String, List<String>> modSourceSets
2021

2122
@Immutable
2223
static class DecompilerModelImpl implements DecompilerModel, Serializable {

src/gradle-tooling-extension/java/com/demonwav/mcdev/platform/mcp/gradle/tooling/fabricloom/FabricLoomModel.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,8 @@ public interface FabricLoomModel {
2222

2323
boolean getSplitMinecraftJar();
2424

25+
Map<String, List<String>> getModSourceSets();
26+
2527
interface DecompilerModel {
2628

2729
String getName();

src/main/kotlin/asset/PlatformAssets.kt

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -47,9 +47,6 @@ object PlatformAssets : Assets() {
4747
val VELOCITY_ICON = loadIcon("/assets/icons/platform/Velocity.png")
4848
val VELOCITY_ICON_2X = loadIcon("/assets/icons/platform/[email protected]")
4949

50-
val LITELOADER_ICON = loadIcon("/assets/icons/platform/LiteLoader.png")
51-
val LITELOADER_ICON_2X = loadIcon("/assets/icons/platform/[email protected]")
52-
5350
val MIXIN_ICON = loadIcon("/assets/icons/platform/Mixins.png")
5451
val MIXIN_ICON_2X = loadIcon("/assets/icons/platform/[email protected]")
5552
val MIXIN_ICON_DARK = loadIcon("/assets/icons/platform/Mixins_dark.png")

src/main/kotlin/creator/buildsystem/gradle-steps.kt

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ import com.demonwav.mcdev.util.SemanticVersion
2020
import com.demonwav.mcdev.util.invokeAndWait
2121
import com.demonwav.mcdev.util.invokeLater
2222
import com.demonwav.mcdev.util.mapFirstNotNull
23-
import com.demonwav.mcdev.util.runGradleTaskAndWait
23+
import com.demonwav.mcdev.util.runGradleTask
2424
import com.demonwav.mcdev.util.runWriteAction
2525
import com.demonwav.mcdev.util.runWriteTask
2626
import com.demonwav.mcdev.util.virtualFileOrError
@@ -31,6 +31,7 @@ import com.intellij.lang.properties.psi.PropertiesFile
3131
import com.intellij.openapi.application.ApplicationManager
3232
import com.intellij.openapi.fileEditor.FileDocumentManager
3333
import com.intellij.openapi.fileEditor.impl.NonProjectFileWritingAccessProvider
34+
import com.intellij.openapi.project.DumbService
3435
import com.intellij.openapi.project.Project
3536
import com.intellij.openapi.startup.StartupManager
3637
import com.intellij.openapi.util.Key
@@ -48,7 +49,7 @@ import org.jetbrains.plugins.gradle.service.execution.GradleRunConfiguration
4849
import org.jetbrains.plugins.gradle.service.project.open.canLinkAndRefreshGradleProject
4950
import org.jetbrains.plugins.gradle.service.project.open.linkAndRefreshGradleProject
5051

51-
val DEFAULT_GRADLE_VERSION = SemanticVersion.release(7, 3, 3)
52+
val DEFAULT_GRADLE_VERSION = SemanticVersion.release(7, 6, 1)
5253
val GRADLE_VERSION_KEY = Key.create<SemanticVersion>("mcdev.gradleVersion")
5354

5455
fun FixedAssetsNewProjectWizardStep.addGradleWrapperProperties(project: Project) {
@@ -63,8 +64,10 @@ abstract class AbstractRunGradleTaskStep(parent: NewProjectWizardStep) : Abstrac
6364

6465
override fun perform(project: Project) {
6566
val outputDirectory = context.projectFileDirectory
66-
runGradleTaskAndWait(project, Path.of(outputDirectory)) { settings ->
67-
settings.taskNames = listOf(task)
67+
DumbService.getInstance(project).runWhenSmart {
68+
runGradleTask(project, Path.of(outputDirectory)) { settings ->
69+
settings.taskNames = listOf(task)
70+
}
6871
}
6972
}
7073
}

src/main/kotlin/creator/buildsystem/maven-steps.kt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -140,6 +140,7 @@ abstract class AbstractPatchPomStep(parent: NewProjectWizardStep) : AbstractLong
140140
// The maven importer requires that the document is saved to disk
141141
val document = PsiDocumentManager.getInstance(project).getDocument(pomPsi)
142142
?: return@runWriteAction
143+
PsiDocumentManager.getInstance(project).doPostponedOperationsAndUnblockDocument(document)
143144
FileDocumentManager.getInstance().saveDocument(document)
144145
}
145146
}

src/main/kotlin/creator/step/AbstractReformatFilesStep.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,11 +10,11 @@
1010

1111
package com.demonwav.mcdev.creator.step
1212

13-
import com.demonwav.mcdev.util.runWriteTask
1413
import com.intellij.codeInsight.actions.ReformatCodeProcessor
1514
import com.intellij.ide.wizard.NewProjectWizardStep
1615
import com.intellij.openapi.application.ReadAction
1716
import com.intellij.openapi.command.WriteCommandAction
17+
import com.intellij.openapi.fileEditor.impl.NonProjectFileWritingAccessProvider
1818
import com.intellij.openapi.project.Project
1919
import com.intellij.openapi.vfs.VfsUtil
2020
import com.intellij.psi.PsiFile
@@ -44,7 +44,7 @@ abstract class AbstractReformatFilesStep(parent: NewProjectWizardStep) : Abstrac
4444
}
4545
files.ifEmpty { return }
4646

47-
runWriteTask {
47+
NonProjectFileWritingAccessProvider.disableChecksDuring {
4848
WriteCommandAction.writeCommandAction(project, *files).withGlobalUndo().run<Throwable> {
4949
ReformatCodeProcessor(project, files, null, false).run()
5050
}

src/main/kotlin/creator/step/FixedAssetsNewProjectWizardStep.kt

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,10 @@ abstract class FixedAssetsNewProjectWizardStep(parent: NewProjectWizardStep) : A
7272
setupAssets(project)
7373

7474
WriteAction.runAndWait<Throwable> {
75+
if (project.isDisposed) {
76+
return@runAndWait
77+
}
78+
7579
val generatedFiles = mutableSetOf<VirtualFile>()
7680
for (asset in assets) {
7781
generateFile(asset)?.let { generatedFiles += it }
@@ -86,7 +90,7 @@ abstract class FixedAssetsNewProjectWizardStep(parent: NewProjectWizardStep) : A
8690
fun runWhenCreated(project: Project, action: () -> Unit) {
8791
if (ApplicationManager.getApplication().isUnitTestMode) {
8892
action()
89-
} else {
93+
} else if (!project.isDisposed) {
9094
StartupManager.getInstance(project).runAfterOpened {
9195
ApplicationManager.getApplication().invokeLater(action, project.disposed)
9296
}

0 commit comments

Comments
 (0)