Fix lint /tableflip

Author: evankanderson

internal/engine/eval/eval.go

@@ -10,6 +10,8 @@ import (
 	"errors"
 	"fmt"
 
+	"github.com/open-feature/go-sdk/openfeature"
+
 	"github.com/mindersec/minder/internal/engine/eval/homoglyphs/application"
 	"github.com/mindersec/minder/internal/engine/eval/jq"
 	"github.com/mindersec/minder/internal/engine/eval/rego"
@@ -19,7 +21,6 @@ import (
 	minderv1 "github.com/mindersec/minder/pkg/api/protobuf/go/minder/v1"
 	"github.com/mindersec/minder/pkg/engine/v1/interfaces"
 	provinfv1 "github.com/mindersec/minder/pkg/providers/v1"
-	"github.com/open-feature/go-sdk/openfeature"
 )
 
 // NewRuleEvaluator creates a new rule data evaluator

internal/engine/eval/rego/lib.go

@@ -45,6 +45,8 @@ var MinderRegoLib = []func(res *interfaces.Result) func(*rego.Rego){
 	JQIsTrue,
 }
 
+// MinderRegoLibExperiments contains Minder-specific functions which
+// should only be exposed when the given experiment is enabled.
 var MinderRegoLibExperiments = map[flags.Experiment][]func(res *interfaces.Result) func(*rego.Rego){
 	flags.TarGzFunctions: {FileArchive, BaseFileArchive},
 	flags.GitPRDiffs: {

internal/engine/eval/rego/lib_test.go

@@ -1003,7 +1003,7 @@ allow {
 					Def:  regoCode,
 				},
 				nil,
-	)
+			)
 			require.NoError(t, err, "could not create evaluator")
 
 			emptyPol := map[string]any{}
@@ -1109,7 +1109,7 @@ allow {
 					Def:  regoCode,
 				},
 				nil,
-	)
+			)
 			require.NoError(t, err, "could not create evaluator")
 
 			_, err = e.Eval(context.Background(), map[string]any{}, nil, &interfaces.Result{})

internal/engine/eval/rego/rego_test.go

@@ -419,7 +419,7 @@ func TestCantCreateEvaluatorWithInvalidConfig(t *testing.T) {
 				Type: "invalid",
 			},
 			nil,
-	)
+		)
 		require.Error(t, err, "should have failed to create evaluator")
 	})
 }

internal/engine/ingester/deps/deps.go

@@ -262,6 +262,7 @@ func (gi *Deps) ingestPullRequest(
 	}, nil
 }
 
+// TODO: this first part is fairly shared with fetchClone from ../git/git.go.
 func (gi *Deps) scanFromUrl(ctx context.Context, url string, branch string) (*sbom.NodeList, *plumbing.Reference, error) {
 	// We clone to the memfs go-billy filesystem driver, which doesn't
 	// allow for direct access to the underlying filesystem. This is

internal/engine/rtengine/cache.go

@@ -128,7 +128,7 @@ func cacheRuleEngine(
 	ctx context.Context,
 	ruleType *db.RuleType,
 	provider provinfv1.Provider,
-	experiments openfeature.IClient,
+	featureFlags openfeature.IClient,
 	ingestCache ingestcache.Cache,
 	engineCache cacheType,
 	dssvc datasourceservice.DataSourcesService,
@@ -156,7 +156,7 @@ func cacheRuleEngine(
 	opts = append(opts, eoptions.WithDataSources(dsreg))
 
 	// Create the rule type engine
-	ruleEngine, err := rtengine2.NewRuleTypeEngine(ctx, pbRuleType, provider, experiments, opts...)
+	ruleEngine, err := rtengine2.NewRuleTypeEngine(ctx, pbRuleType, provider, featureFlags, opts...)
 	if err != nil {
 		return nil, fmt.Errorf("error creating rule type engine: %w", err)
 	}

internal/flags/constants.go

@@ -21,6 +21,7 @@ const (
 	PRCommentAlert Experiment = "pr_comment_alert"
 	// GitPRDiffs enables the git ingester for pull requests.
 	GitPRDiffs Experiment = "git_pr_diffs"
-	// Add tar.gz functions to the rego evaluation environment.
+	// TarGzFunctions enables functions to produce tar.gz data in the rego
+	// evaluation environment.
 	TarGzFunctions Experiment = "tar_gz_functions"
 )