Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom version sorting in detect-versions for latestVersionTag #7

Closed
DenKoren opened this issue Feb 16, 2022 · 1 comment
Closed

Custom version sorting in detect-versions for latestVersionTag #7

DenKoren opened this issue Feb 16, 2022 · 1 comment
Assignees

Comments

@DenKoren
Copy link
Member

When git repository faces both 'v-' prefixed version tags and regular tags, it splits them into two groups during sort even when we ask it to sort 'as version numbers'.
This causes wrong 'latest' version detection.

I tried to solve the problem by giving 'v-' prefixed tags higher priority than regular, but this logic sucks when we switch FROM v-prefixed style TO regular.

This problem should be solved with plain JS :(

@DenKoren DenKoren self-assigned this Feb 16, 2022
@DenKoren
Copy link
Member Author

Done.
github docker workflow is now able to keep version tag updated for each release.

E.g. when you release v2.12.4 and it is latest modification of 'v2', you can set workflow to update :2 tag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant