Fixed uninitiated variable in stripe processing

mikebronner · mikebronner · commit d4255935e4db · 2018-05-05T11:24:55.000-07:00
diff --git a/src/Http/Requests/RecordStripeEvent.php b/src/Http/Requests/RecordStripeEvent.php
@@ -79,6 +79,7 @@ private function recordCharge(array $transaction, $user)
 
     private function recordSubscription(array $transaction, $user, array $originalValues = [])
     {
+        $trackingData = [];
         $planStatus = array_key_exists('status', $transaction) ? $transaction['status'] : null;
         $planName = isset($transaction['plan']['name']) ? $transaction['plan']['name'] : null;
         $planStart = array_key_exists('start', $transaction) ? $transaction['start'] : null;
@@ -169,9 +170,7 @@ private function recordSubscription(array $transaction, $user, array $originalVa
             }
         }
 
-        if ($trackingData) {
-            event(new MixpanelEvent($user, $trackingData, 0, $profileData));
-        }
+        event(new MixpanelEvent($user, $trackingData, 0, $profileData));
     }
 
     private function findStripeCustomerId(array $transaction)

Original file line number	Diff line number	Diff line change
`@@ -79,6 +79,7 @@ private function recordCharge(array $transaction, $user)`
`79`	`79`
`80`	`80`	`private function recordSubscription(array $transaction, $user, array $originalValues = [])`
`81`	`81`	`{`
	`82`	`+ $trackingData = [];`
`82`	`83`	`$planStatus = array_key_exists('status', $transaction) ? $transaction['status'] : null;`
`83`	`84`	`$planName = isset($transaction['plan']['name']) ? $transaction['plan']['name'] : null;`
`84`	`85`	`$planStart = array_key_exists('start', $transaction) ? $transaction['start'] : null;`
`@@ -169,9 +170,7 @@ private function recordSubscription(array $transaction, $user, array $originalVa`
`169`	`170`	`}`
`170`	`171`	`}`
`171`	`172`
`172`		`- if ($trackingData) {`
`173`		`- event(new MixpanelEvent($user, $trackingData, 0, $profileData));`
`174`		`- }`
	`173`	`+ event(new MixpanelEvent($user, $trackingData, 0, $profileData));`
`175`	`174`	`}`
`176`	`175`
`177`	`176`	`private function findStripeCustomerId(array $transaction)`