Skip to content

Commit 805b33f

Browse files
Conversion from Socket.IO sid to Engine.IO sid
1 parent af2e263 commit 805b33f

File tree

3 files changed

+10
-1
lines changed

3 files changed

+10
-1
lines changed

README.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ is to use the same version of this package for the client and the server. If you
2121
using this package with a different client or server, then you must ensure the
2222
versions are compatible.
2323

24-
The version compatiblity chart below maps versions of this package to versions
24+
The version compatibility chart below maps versions of this package to versions
2525
of the JavaScript reference implementation and the versions of the Socket.IO and
2626
Engine.IO protocols.
2727

socketio/base_manager.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,10 @@ def sid_from_eio_sid(self, eio_sid, namespace):
6262
if namespace in self.rooms:
6363
return self.rooms[namespace][None].inverse.get(eio_sid)
6464

65+
def eio_sid_from_sid(self, sid, namespace):
66+
if namespace in self.rooms:
67+
return self.rooms[namespace][None].get(sid)
68+
6569
def can_disconnect(self, sid, namespace):
6670
return self.is_connected(sid, namespace)
6771

tests/common/test_base_manager.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,11 @@ def test_connect(self):
2828
assert dict(self.bm.rooms['/foo'][None]) == {sid: '123'}
2929
assert dict(self.bm.rooms['/foo'][sid]) == {sid: '123'}
3030
assert self.bm.sid_from_eio_sid('123', '/foo') == sid
31+
assert self.bm.sid_from_eio_sid('1234', '/foo') is None
32+
assert self.bm.sid_from_eio_sid('123', '/bar') is None
33+
assert self.bm.eio_sid_from_sid(sid, '/foo') == '123'
34+
assert self.bm.eio_sid_from_sid('x', '/foo') is None
35+
assert self.bm.eio_sid_from_sid(sid, '/bar') is None
3136

3237
def test_pre_disconnect(self):
3338
sid1 = self.bm.connect('123', '/foo')

0 commit comments

Comments
 (0)