Skip to content

drop support for node < 18 #701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

drop support for node < 18 #701

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
125a6cf
drop support for node < 18
jelhan Dec 3, 2024
53074e7
use compatible versions in ember try scenarios
jelhan Dec 3, 2024
0f0b469
ember-leaflet-marker-cluster supports old Leaflet version only until …
jelhan Dec 3, 2024
99024bd
use compatible ember-resolver version
jelhan Dec 3, 2024
36e1b9b
fix formatting issue
jelhan Dec 3, 2024
e42fc71
ember-compatibility-tools v2 required for Ember v6
jelhan Dec 3, 2024
77a15cd
ember-resolver v9 required for ember-lts v4.4 scenario
jelhan Dec 3, 2024
711f198
downgrade ember-resolver to 8.1.0
jelhan Dec 3, 2024
0909ada
skip beta and canary scenarios
jelhan Dec 3, 2024
c76ab3a
add Ember 4.12 and 5.12 scenarios in CI
jelhan Dec 3, 2024
94891c3
disable tests for Embroider and latest relase for now
jelhan Dec 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ on:
pull_request: {}

env:
NODE_VERSION: 14
NODE_VERSION: 18

concurrency:
group: ci-${{ github.head_ref || github.ref }}
Expand Down Expand Up @@ -63,11 +63,13 @@ jobs:
- ember-lts-3.28-leaflet-0.7.7
- ember-lts-4.4
- ember-lts-4.8
- ember-release
- ember-beta
- ember-canary
- embroider-safe
- embroider-optimized
- ember-lts-4.12
- ember-lts-5.12
# - ember-release
# - ember-beta
# - ember-canary
# - embroider-safe
# - embroider-optimized
Comment on lines +68 to +72
Copy link
Contributor Author

@jelhan jelhan Dec 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hard to get those tests working again with the incompatible peer dependencies etc. I would recommend disabling the tests for now and enabling them again later.


steps:
- uses: actions/checkout@v3
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@
"crypto"
],
"engines": {
"node": "14.* || 16.* || >= 18"
"node": "18.* || 20.* || >= 22"
},
"keywords": [
"ember-addon",
Expand Down
22 changes: 22 additions & 0 deletions tests/dummy/config/ember-try.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ module.exports = async function () {
devDependencies: {
'ember-source': '~3.28',
'ember-data': '~3.28',
'ember-leaflet-marker-cluster': '0.2.0',
'ember-resolver': '^8.1.0',
leaflet: '~0.7.7'
}
}
Expand All @@ -20,6 +22,7 @@ module.exports = async function () {
name: 'ember-lts-4.4',
npm: {
devDependencies: {
'ember-resolver': '^8.1.0',
'ember-source': '~4.4.0'
}
}
Expand All @@ -32,10 +35,27 @@ module.exports = async function () {
}
}
},
{
name: 'ember-lts-4.12',
npm: {
devDependencies: {
'ember-source': '~4.12.0'
}
}
},
{
name: 'ember-lts-5.12',
npm: {
devDependencies: {
'ember-source': '~5.12.0'
}
}
},
{
name: 'ember-release',
npm: {
devDependencies: {
'ember-composability-tools': '^2.0.0',
'ember-source': await getChannelURL('release')
}
}
Expand All @@ -44,6 +64,7 @@ module.exports = async function () {
name: 'ember-beta',
npm: {
devDependencies: {
'ember-composability-tools': '^2.0.0',
'ember-source': await getChannelURL('beta')
}
}
Expand All @@ -52,6 +73,7 @@ module.exports = async function () {
name: 'ember-canary',
npm: {
devDependencies: {
'ember-composability-tools': '^2.0.0',
'ember-source': await getChannelURL('canary')
}
}
Expand Down
Loading