drop support for node < 18 #701
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jelhan
commented
Dec 3, 2024
Comment on lines
+68
to
+72
| # - ember-release | ||
| # - ember-beta | ||
| # - ember-canary | ||
| # - embroider-safe | ||
| # - embroider-optimized |
Contributor
Author
There was a problem hiding this comment.
Hard to get those tests working again with the incompatible peer dependencies etc. I would recommend disabling the tests for now and enabling them again later.
Contributor
Author
|
@miguelcobain Any chance you can have a look at this one to unblock #700 and resolve #698? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drops support for Node < 18 and all other versions, which reached end of life already.
The newer NPM version shipped with node 18 uncovered many peer dependency issues in the ember try scenarios.
This is a breaking change.