Fix wrong update warnings. Fixes #24

clarkwinkelmann · clarkwinkelmann · commit e6c69768c396 · 2022-01-29T17:30:37.000+01:00
diff --git a/app/Resources/ExtensionResource.php b/app/Resources/ExtensionResource.php
@@ -25,7 +25,8 @@ public function toArray($request): array
 
             $attributes['possible_versions'] = $possibleVersions;
             // We know possible_versions are sorted from lowest to highest in the task
-            $attributes['update_available'] = Comparator::greaterThan($this->resource->last_version, Arr::last($possibleVersions));
+            // We need to trim the "v" in front of version because it creates issue if one of the versions has it and another doesn't
+            $attributes['update_available'] = Comparator::greaterThan(trim($this->resource->last_version, 'v'), trim(Arr::last($possibleVersions), 'v'));
         }
 
         return [

Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,8 @@ public function toArray($request): array`
`25`	`25`
`26`	`26`	`$attributes['possible_versions'] = $possibleVersions;`
`27`	`27`	`// We know possible_versions are sorted from lowest to highest in the task`
`28`		`- $attributes['update_available'] = Comparator::greaterThan($this->resource->last_version, Arr::last($possibleVersions));`
	`28`	`+ // We need to trim the "v" in front of version because it creates issue if one of the versions has it and another doesn't`
	`29`	`+ $attributes['update_available'] = Comparator::greaterThan(trim($this->resource->last_version, 'v'), trim(Arr::last($possibleVersions), 'v'));`
`29`	`30`	`}`
`30`	`31`
`31`	`32`	`return [`