Handle Cloudflare Rocket Loader more gracefully

Author: clarkwinkelmann

app/FlarumVersionGuesser.php

@@ -13,7 +13,8 @@ class FlarumVersionGuesser
     public function guess(string $html, string $bootScript): array
     {
         // Separate JSON payload tag was introduced in 1.4 https://github.com/flarum/framework/pull/3461
-        if (preg_match('~<script\s+id="flarum-json-payload"\s+type="application/json"~', $html) === 1) {
+        // Cloudflare Rocket Loader removes the quotes around the ID
+        if (preg_match('~<script\s+id=("flarum-json-payload"|flarum-json-payload)\s+type="application/json"~', $html) === 1) {
             return [
                 FlarumVersion::V1_4_0,
                 FlarumVersion::V1_5_0,
@@ -37,7 +38,8 @@ public function guess(string $html, string $bootScript): array
         }
 
         // Hashes changed in Flarum 1.0 https://github.com/flarum/core/pull/2805
-        if (preg_match('~/assets/forum\.js\?v=[0-9a-f]{8}"></script>~', $html) === 1) {
+        // Cloudflare Rocket Loader adds a type="" attribute to all script tags
+        if (preg_match('~/assets/forum\.js\?v=[0-9a-f]{8}"\s*(type="[^"]+")?></script>~', $html) === 1) {
             return [
                 FlarumVersion::V1_0_0,
                 FlarumVersion::V1_0_1,

app/Jobs/ScanHomePage.php

@@ -44,6 +44,14 @@ protected function handleTask()
         $versions = null;
 
         $homepage->filter('body script')->each(function (Crawler $script) use ($bodyContent, &$bootPayload, &$versions) {
+            // Cloudflare's Rocket Loader complicates the parsing of known tags
+            // We'll add a warning about so the user is aware why the scan might be incomplete
+            if (str_contains($script->attr('src'), 'cloudflare-static/rocket-loader')) {
+                $this->data['cloudflareRocketLoader'] = true;
+
+                return;
+            }
+
             $content = $script->text('', false);
 
             // Starting with Flarum 1.4, the boot payload is in its own tag

resources/assets/js/pages/ScanPage.js

@@ -224,6 +224,20 @@ export default {
             return getObjectKey(task.attributes.data, key, defaultValue);
         }
 
+        if (reportKey('ScanHomePage', 'cloudflareRocketLoader')) {
+            suggestions.push({
+                title: 'Rocket Loader',
+                suggest: [
+                    'This website appears to be enhanced with ',
+                    m('a', {
+                        href: 'https://developers.cloudflare.com/fundamentals/speed/rocket-loader/',
+                    }, 'Cloudflare Rocket Loader'),
+                    '. Unfortunately not all features of the Lab work with Rocket Loader at the moment. ',
+                    'You might see incomplete results.',
+                ],
+            });
+        }
+
         // We could probably switch to ScanGuessVersion but if it ain't broken...
         const legacyVersions = reportKey('ScanHomePage', 'versions', []);