Fix ping job not silencing ConnectException

clarkwinkelmann · clarkwinkelmann · commit 0d581d068b73 · 2022-05-02T18:17:42.000+02:00
diff --git a/app/Jobs/WebsitePing.php b/app/Jobs/WebsitePing.php
@@ -4,7 +4,7 @@
 
 use App\ScannerClient;
 use App\Website;
-use GuzzleHttp\Exception\RequestException;
+use GuzzleHttp\Exception\TransferException;
 use Illuminate\Bus\Queueable;
 use Illuminate\Queue\SerializesModels;
 use Illuminate\Queue\InteractsWithQueue;
@@ -58,7 +58,7 @@ public function handle()
                         }
                     });
                 }
-            } catch (RequestException $exception) {
+            } catch (TransferException $exception) {
                 // Ignore connect exceptions, they will be considered as non-flarum
                 // We also need to catch RequestException for certificate issues and such
             }

Original file line number	Diff line number	Diff line change
`@@ -4,7 +4,7 @@`
`4`	`4`
`5`	`5`	`use App\ScannerClient;`
`6`	`6`	`use App\Website;`
`7`		`-use GuzzleHttp\Exception\RequestException;`
	`7`	`+use GuzzleHttp\Exception\TransferException;`
`8`	`8`	`use Illuminate\Bus\Queueable;`
`9`	`9`	`use Illuminate\Queue\SerializesModels;`
`10`	`10`	`use Illuminate\Queue\InteractsWithQueue;`
`@@ -58,7 +58,7 @@ public function handle()`
`58`	`58`	`}`
`59`	`59`	`});`
`60`	`60`	`}`
`61`		`- } catch (RequestException $exception) {`
	`61`	`+ } catch (TransferException $exception) {`
`62`	`62`	`// Ignore connect exceptions, they will be considered as non-flarum`
`63`	`63`	`// We also need to catch RequestException for certificate issues and such`
`64`	`64`	`}`