Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DetourUpdateThread(GetCurrentThread()) is a no-op #723

Closed
DrusTheAxe opened this issue Jan 26, 2021 · 1 comment
Closed

DetourUpdateThread(GetCurrentThread()) is a no-op #723

DrusTheAxe opened this issue Jan 26, 2021 · 1 comment
Labels
no-issue-activity

Comments

@DrusTheAxe
Copy link
Member

Line 333 and 345 in dllmain.cpp call DetourUpdateThread(GetCurrentThread())

As noted in MSIX Dynamic Dependencies PR #393 DetourUpdateThread(GetCurrentThread()) is a no-op, see microsoft/Detours#151 and consider using CreateToolhelp32Snapshot to enumerate and update all other threads
@DrusTheAxe DrusTheAxe mentioned this issue Jan 26, 2021
Merged
@DrusTheAxe DrusTheAxe mentioned this issue Feb 9, 2021
Closed
@github-actions
Copy link

github-actions bot commented Mar 4, 2023

This issue is stale because it has been open 10 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
no-issue-activity
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DrusTheAxe