Add PineFlash 0.5.5 #201676
Open
Add PineFlash 0.5.5 #201676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
/AzurePipelines run |
|
@microsoft-github-policy-service agree |
1 task
wingetbot
added
New-Package
Azure-Pipeline-Passed
|
The application seemed to install correctly, but I couldn't get it to run when launched. This EXE gave an error: Verify while here: |
stephengillie
added
the
Needs-Author-Feedback
|
Interesting - didn't run into that when doing sandbox validation. Will have to test on a fresh VM later. Will investigate.
…________________________________
|
microsoft-github-policy-service
bot
added
Needs-Attention
Does look like blisp requires vcredist as mentioned - will add. Having launch issues on a fresh vm vs sandbox/ bare metal. Might be something driver related? Still looking. |
stephengillie
requested changes
Dec 26, 2024
| PackageIdentifier: Spagett1.PineFlash | ||
| PackageVersion: 0.5.5 | ||
| InstallerType: inno | ||
| Installers: |
There was a problem hiding this comment.
Suggested change
| Installers: | |
| Dependencies: | |
| PackageDependencies: | |
| - PackageIdentifier: Microsoft.VCRedist.2015+.x64 | |
| Installers: |
microsoft-github-policy-service
bot
added
the
Changes-Requested
microsoft-github-policy-service
bot
added
the
Needs-Author-Feedback
stephengillie
removed
the
Needs-Attention
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist for Pull Requests
Manifests
winget validate --manifest <path>?winget install --manifest <path>?Note:
<path>is the directory's name containing the manifest you're submitting.Microsoft Reviewers: Open in CodeFlow