Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Update Request]: SomePythonThings.WingetUIStore #173379

Closed
ghost opened this issue Sep 14, 2024 · 15 comments · Fixed by #174277
Closed

[Update Request]: SomePythonThings.WingetUIStore #173379

ghost opened this issue Sep 14, 2024 · 15 comments · Fixed by #174277
Labels
In-PR Package-Update This package needs to be updated
Milestone

Comments

@ghost
Copy link

ghost commented Sep 14, 2024

What type of update are you requesting?

A change to the Package Identifier

Current Package Identifier

SomePythonThings.WingetUIStore

Package Version

All

Please describe the changes you would like to see

Suggested new package identifier:
MartiCliment.UniGetUI

Motivation:

  • The official publisher and author of the app is Martí Climent, not "SomePythonThings".
  • The official name of the app is UniGetUI, not WingetUI.
@ghost ghost added Help-Wanted This is a good candidate work item from the community. Package-Update This package needs to be updated labels Sep 14, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Triage This work item needs to be triaged by a member of the core team. label Sep 14, 2024
@vikingnope
Copy link
Contributor

@marticliment would you agree with this change, or would you suggest leaving it as is?

@marticliment
Copy link
Contributor

Yes, it definitely makes sense to make the change

@vikingnope
Copy link
Contributor

vikingnope commented Sep 15, 2024

Should have probably added this to previous question but here goes:

@marticliment do you think we should:

  1. Remove previous WingetUI in total and just create a manifest for UniGetUI
    OR
  2. Keep WingetUI here and remove the UniGetUI manifests from it, and just create a new manifest for UniGetUI?

I think it honestly just depends if you want to keep the previous WingetUI branding or not

@marticliment
Copy link
Contributor

Ideally it would be better to follow option 1, to prevent confusion, but I don't know if it is feasible and acceptable to delete an entire package and then publish it again with different names. Having that said, either if it ends up being option 1 or 2 it will be ok for me.

@vikingnope
Copy link
Contributor

vikingnope commented Sep 15, 2024

@stephengillie, would you suggest option 1 or 2 based on Marti's feedback and winget's terms?

@stephengillie
Copy link
Collaborator

I agree with @ marticliment that the first option is better. While it would be possible for us to continue offering WinGetUI as a historical record, I'm not sure how much demand there is for it.

A third possible option could be leaving the manifests before the name change as-is, and only moving the post-rename manifests. This could reduce workload while also preserving the older manifest versions.

Note

Moving packages from one PackageIdentifier to another can be a lot of work. Foreach manifest version, 2 PRs are needed - one to add new and one to remove old. This process always winds up having some level of coordination between the submitter and a moderator to approve, and with the appropriate preparation can go very smoothly.

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Triage This work item needs to be triaged by a member of the core team. label Sep 16, 2024
@vikingnope
Copy link
Contributor

vikingnope commented Sep 16, 2024

I agree with @ marticliment that the first option is better. While it would be possible for us to continue offering WinGetUI as a historical record, I'm not sure how much demand there is for it.

A third possible option could be leaving the manifests before the name change as-is, and only moving the post-rename manifests. This could reduce workload while also preserving the older manifest versions.

Note

Moving packages from one PackageIdentifier to another can be a lot of work. Foreach manifest version, 2 PRs are needed - one to add new and one to remove old. This process always winds up having some level of coordination between the submitter and a moderator to approve, and with the appropriate preparation can go very smoothly.

So what I will do is follow what you suggested which is to create the new manifest then remove the old one. 😊

I don't think WingetUI is still in demand since most people always want the latest version, which in this case is UniGetUI

@vikingnope
Copy link
Contributor

I will continue the rest when these commit just to make sure everything is correct

@marticliment
Copy link
Contributor

Assuming we chose to delete the old manifests and just start from scratch (Option 1), would it be possible to delete all the manifests in one single PR? Or we'd still need to do one manifest at a time?

I don't think WingetUI is still in demand since most people always want the latest version, which in this case is UniGetUI

I agree, and all the installers for older versions are still (and will be) available on GitHub, so installing older versions shouldn't be an issue.

@vikingnope
Copy link
Contributor

vikingnope commented Sep 16, 2024

Assuming we chose to delete the old manifests and just start from scratch (Option 1), would it be possible to delete all the manifests in one single PR? Or we'd still need to do one manifest at a time?

They will have to be removed in separate PRs one-by-one but that is easy with Komac, the hardest part is transferring all of the UniGetUI manifests because they have to be done manually, luckily this was caught early on so not many versions... 😌

@marticliment
Copy link
Contributor

Lots of thanks, @ vikingnope. I will be updating my workflow so new releases automatically point to the new package

@vikingnope
Copy link
Contributor

When these are committed I will start removing all the packages from SomePythonThings.WingetUI

@vikingnope
Copy link
Contributor

Multiple PRs have been scheduled so that this can be completed

@microsoft-github-policy-service microsoft-github-policy-service bot added In-PR and removed Help-Wanted This is a good candidate work item from the community. labels Sep 19, 2024
@vikingnope
Copy link
Contributor

Not entirely finished, still a bit more to go

@vikingnope
Copy link
Contributor

This has officially been completed, I thank you all for your patience. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
In-PR Package-Update This package needs to be updated
Projects
None yet
4 participants