Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WDF_STRUCTURE_SIZE macro equivalent #242

Open
wmmc88 opened this issue Nov 7, 2024 · 3 comments
Open

Add WDF_STRUCTURE_SIZE macro equivalent #242

wmmc88 opened this issue Nov 7, 2024 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@wmmc88
Copy link
Collaborator

wmmc88 commented Nov 7, 2024

WDF_STRUCTURE_SIZE is a macro available in the WDK, but isn't available in wdk-sys since bindgen can't generate macros. WDF_STRUCTURE_SIZE is useful since many of the _INIT macros are also not available right now. A 1:1 implementation of WDF_STRUCTURE_SIZE should be made available in wdk-sys, although an equivalent shouldn't be needed in wdk given that the safe abstractions shouldn't need to do any of the c-style manual initializations.

@0xflux
Copy link

0xflux commented Dec 9, 2024

I'd like to have a look at this @wmmc88. Would this live in wdk-sys/ntddk.rs?

@wmmc88
Copy link
Collaborator Author

wmmc88 commented Dec 10, 2024

I'd like to have a look at this @wmmc88. Would this live in wdk-sys/ntddk.rs?

It would live in wdf.rs, however i would hold off on doing anything here yet since we're investigating whether we can look into using bindgen's new clang_macro_fallback feature

@0xflux
Copy link

0xflux commented Dec 11, 2024

Ok no probs! Looking for some places to contribute so I'll keep my eyes open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants