Commit f5cedc3
authored
Emit style modules via importmap + dataURI instead of <style type="module"> (#325)
* feat(handler): emit CSS modules via `<script type="importmap">` data URIs
Replace the per-component `<style type="module" specifier="X">CSS</style>`
emission with `<script type="importmap">{"imports":{"X":"data:text/css,…"}}</script>`.
Why
---
The `<style type="module">` shape is a non-standard CSS-module-style-tag
prototype that has not shipped in all host browsers. Import Maps + `data:text/css,…` URIs achieve the same end -
the browser resolves a CSS module by specifier - using only standards-
track features available in Chrome 133+.
The shape change is transparent to downstream consumers: the framework's
client-side adoption code resolves CSS modules by specifier the same way
in both forms, and `shadowrootadoptedstylesheets` continues to work unchanged.
What changed
------------
* New private method `emit_css_module_importmap(specifier, css, ctx)`
in `crates/webui-handler/src/lib.rs`. Percent-encodes only the bytes
that would actually mis-parse in a data URI (`%` `#` `"` whitespace
control chars, non-ASCII) - keeps human-readable CSS readable in
DevTools' importmap view.
* Builds the JSON body with `serde_json::json!` so the specifier and
data URI are always correctly JSON-escaped.
* Both emission call sites - `emit_css_module` (per-component first
render) and the `body_end` reachable-but-unrendered loop — route
through the new helper.
* CSP nonce is applied identically to the legacy `<style type="module">`
path and to the bootstrap `<script>` emit, so the existing nonce
tests stay green (assertions updated to the new emission shape).
* Tests updated: positive-shape asserts now check for
`<script type="importmap"…>` and the embedded data URI; negative-
shape asserts in non-module strategies additionally guard against
accidental importmap emission.
Tests
-----
`cargo test -p microsoft-webui-handler --lib` - 285/285 pass.
`cargo test --workspace --lib` - all crates green.
* Initial commit1 parent c0bd525 commit f5cedc3
19 files changed
Lines changed: 460 additions & 195 deletions
File tree
- crates
- webui-handler/src
- webui-parser/src
- plugin
- webui/src
- docs/guide
- cli
- concepts
- integrations
- examples/app/commerce/server/src
- packages
- webui-framework
- src/element
- webui-router/src
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
319 | 319 | | |
320 | 320 | | |
321 | 321 | | |
322 | | - | |
| 322 | + | |
323 | 323 | | |
324 | 324 | | |
325 | 325 | | |
| |||
499 | 499 | | |
500 | 500 | | |
501 | 501 | | |
502 | | - | |
| 502 | + | |
| 503 | + | |
503 | 504 | | |
504 | 505 | | |
505 | 506 | | |
| |||
945 | 946 | | |
946 | 947 | | |
947 | 948 | | |
948 | | - | |
949 | | - | |
950 | | - | |
| 949 | + | |
| 950 | + | |
| 951 | + | |
951 | 952 | | |
952 | 953 | | |
953 | 954 | | |
954 | 955 | | |
955 | 956 | | |
956 | 957 | | |
957 | | - | |
| 958 | + | |
958 | 959 | | |
959 | 960 | | |
960 | 961 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
0 commit comments