Skip to content

Commit 03cdccd

Browse files
fix(ci): run build+e2e on Windows for matching screenshots
Switch build+e2e job to windows-latest so Playwright screenshots match local development baselines (same fonts, same rendering). Reverts ignoreSnapshots workaround — screenshots now run in CI too.
1 parent 82cae60 commit 03cdccd

6 files changed

Lines changed: 2 additions & 7 deletions

File tree

.github/workflows/pr.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,13 +73,13 @@ jobs:
7373
# ── Phase 2: Build + E2E (parallel with test) ───────────────────────
7474
build:
7575
name: Build + E2E
76-
runs-on: ubuntu-latest
76+
runs-on: windows-latest
7777
needs: lint
7878
steps:
7979
- uses: actions/checkout@v4
8080

8181
- name: Install protoc
82-
run: sudo apt-get update -qq && sudo apt-get install -y -qq protobuf-compiler
82+
run: choco install protoc -y
8383

8484
- name: Setup Rust
8585
uses: dtolnay/rust-toolchain@stable

examples/app/calculator/playwright.config.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ export default defineConfig({
99
use: {
1010
baseURL: 'http://127.0.0.1:3002',
1111
screenshot: 'only-on-failure',
12-
ignoreSnapshots: !!process.env.CI,
1312
},
1413
projects: [
1514
{ name: 'chromium', use: { browserName: 'chromium' } },

examples/app/commerce/playwright.config.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ export default defineConfig({
99
use: {
1010
baseURL: 'http://127.0.0.1:3004',
1111
screenshot: 'only-on-failure',
12-
ignoreSnapshots: !!process.env.CI,
1312
},
1413
projects: [
1514
{

examples/app/contact-book-manager/playwright.config.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ export default defineConfig({
99
use: {
1010
baseURL: 'http://127.0.0.1:3003',
1111
screenshot: 'only-on-failure',
12-
ignoreSnapshots: !!process.env.CI,
1312
},
1413
projects: [
1514
{ name: 'chromium', use: { browserName: 'chromium' } },

examples/app/hello-world/playwright.config.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ export default defineConfig({
99
use: {
1010
baseURL: 'http://127.0.0.1:3000',
1111
screenshot: 'only-on-failure',
12-
ignoreSnapshots: !!process.env.CI,
1312
},
1413
projects: [
1514
{ name: 'chromium', use: { browserName: 'chromium' } },

examples/app/routes/playwright.config.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ export default defineConfig({
99
use: {
1010
baseURL: 'http://127.0.0.1:3005',
1111
screenshot: 'only-on-failure',
12-
ignoreSnapshots: !!process.env.CI,
1312
},
1413
projects: [
1514
{ name: 'chromium', use: { browserName: 'chromium' } },

0 commit comments

Comments
 (0)