Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update JSDoc on updateWorkspaceFolders when extension host will restart #165010

Closed
paulober opened this issue Oct 30, 2022 · 3 comments
Closed

Update JSDoc on updateWorkspaceFolders when extension host will restart #165010

paulober opened this issue Oct 30, 2022 · 3 comments
Assignees
Labels
api insiders-released Patch has been released in VS Code Insiders workbench-workspace Workspace issues
Milestone

Comments

@paulober
Copy link

Does this issue occur when all extensions are disabled?: Yes/No
No

  • VS Code Version: 1.72.2
  • OS Version: Windows 11 22H2

Steps to Reproduce:

  1. Create a new extension with it's own filesystem provider.
  2. Mount the new filesystem with updateWorkspaceFolders.
  3. VSCode reloads extension

Bug:
Every time i mount my filesystem the hole extension reloads:

[2022-10-30 16:10:57.926] [exthost] [info] Extension host terminating: received terminate message from renderer
[2022-10-30 16:10:57.949] [exthost] [error] ProxyResolver#resolveProxy DIRECT Canceled: Canceled

I think it has to do with the note you added to updateWorkspaceFolders jsdoc:
If the first workspace folder is added, removed or changed, the currently executing extensions (including the one that called this method) will be terminated and restarted so that the (deprecated) rootPath property is updated to point to the first workspace folder.

So the bug is that it also reloads the extensions if you add a workspace and not change or remove the first workspace folder.
That's realy bad if your extension keeps a constant connection with a remote location to keep the remoteFilesystem connected which will be terminated if the extension gets restarted by vscode.

@bpasero
Copy link
Member

bpasero commented Nov 8, 2022

Yeah we probably should update the JSDoc that we also reload extension host when going from 1 folder to 2 or more folders.

@bpasero bpasero changed the title [BUG] VSCode reloading extension on ADDING new workspaceFolder Update JSDoc on updateWorkspaceFolders when extension host will restart Nov 8, 2022
@bpasero bpasero added api workbench-workspace Workspace issues labels Nov 8, 2022
@paulober
Copy link
Author

paulober commented Nov 8, 2022

@bpasero And is there any way that i can avoid this behaviour when mounting my remote workspace?

@bpasero
Copy link
Member

bpasero commented Nov 8, 2022

No, see #69335

@bpasero bpasero added this to the November 2022 milestone Nov 8, 2022
@bpasero bpasero closed this as completed in 8f7aec2 Nov 8, 2022
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Nov 8, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api insiders-released Patch has been released in VS Code Insiders workbench-workspace Workspace issues
Projects
None yet
Development

No branches or pull requests

4 participants