Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If Explorer file sorting is set to "modified", sorting only shows correct for uncommited files by modified date. Sorting is displayed incorrectly in alphabetical order for folders and commited files #407

Open
Tracked by #408
devgid opened this issue Dec 28, 2023 · 0 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug
Milestone

Comments

@devgid
Copy link

devgid commented Dec 28, 2023

Type: Bug

  1. Open a local filestyem folder as a workspace in VSCode

  2. Go to Settings-> Explorer:Sort Order (workspace) and set it to Modified
    Notice the "Modified" help text reads "Files and Folders are Sorted by Last Modified Date"

  3. In the File Explorer Panel notice that when you edit a file that both File and Folder moves to top of the File Explorer Panel.
    This is correct behaviour.

  4. Open a new workspace but this time using the GitHub Repositories VSCode Extension.

  5. Go to Settings-> Explorer:Sort Order (workspace) and set it to Modified
    Notice the "Modified" help text reads "Files and Folders are Sorted by Last Modified Date"

  6. In the File Explorer Panel notice that when you edit a file that only the File and not the Folder moves to top of the File Explorer Panel. The folders stay sorted in alphabetical order in File Explorer.
    This is not correct behaviour.
    The folders should also be sorted by Last modified date which works correctly for workspaces using the local file system but not for Github Repositories VSCode Extension (virtual file system)

  7. Open a new workspace using the GitHub Repositories VSCode Extension.

  8. Go to Settings-> Explorer:Sort Order (workspace) and set it to Modified
    Notice the "Modified" help text reads "Files and Folders are Sorted by Last Modified Date"

  9. In the File Explorer Panel notice that when you edit a file that only the File and not the Folder moves to top of the File Explorer Panel. The folders stay sorted in alphabetical order in File Explorer.

  10. Notice further if you commit and push this edited file change you just made, the file jumps back to alphabetical order.
    This is not correct behaviour.
    The github committed files should instead be sorted by Last modified date.

Extension version: 0.62.0
VS Code version: Code 1.85.1 (0ee08df0cf4527e40edc9aa28f4b5bd38bbff2b2, 2023-12-13T09:49:37.021Z)
OS version: Windows_NT x64 10.0.22621
Modes:

System Info
Item Value
CPUs 12th Gen Intel(R) Core(TM) i7-1255U (12 x 2611)
GPU Status 2d_canvas: enabled
canvas_oop_rasterization: enabled_on
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
webgpu: enabled
Load (avg) undefined
Memory (System) 31.71GB (7.04GB free)
Process Argv --crash-reporter-id f4d81ca4-36c1-499e-8b32-b8cc4bb262e0
Screen Reader no
VM 0%
A/B Experiments
vsliv368cf:30146710
vsreu685:30147344
vspor879:30202332
vspor708:30202333
vspor363:30204092
vswsl492cf:30256860
vslsvsres303:30308271
vserr242:30382549
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vshan820:30294714
vstes263:30335439
vscod805cf:30301675
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
vsaa593cf:30376535
py29gd2263:30899288
vsclangdc:30486549
c4g48928:30535728
dsvsc012:30540252
azure-dev_surveyone:30548225
f6dab269:30613381
2i9eh265:30646982
showlangstatbar:30737416
fixshowwlkth:30771522
showindicator:30805244
pythongtdpath:30769146
i26e3531:30792625
welcomedialog:30910333
pythonidxpt:30866567
pythonnoceb:30805159
asynctok:30898717
dsvsc013:30795093
dsvsc014:30804076
dsvsc015:30845448
pythontestfixt:30902429
pythonregdiag2:30926735
pyreplss1:30897532
pythonmypyd1:30879173
pythoncet0:30885854
h48ei257:30885898
pythontbext0:30879054
dsvsc016:30899300
dsvsc017:30899301
dsvsc018:30899302
aa_t_chat:30882232
cp7184t:30925682

@devgid devgid changed the title If Explorer file sorting is set to "modified" it sorts files and not folders but only for Github repositories (virtual workspaces) If Explorer file sorting is set to "modified" it sorts files and not folders but only for Github repositories extention(virtual workspaces) Dec 28, 2023
@devgid devgid changed the title If Explorer file sorting is set to "modified" it sorts files and not folders but only for Github repositories extention(virtual workspaces) If Explorer file sorting is set to "modified" it sorts files and not folders but only for Github repositories extension (virtual workspaces) Dec 28, 2023
@devgid devgid changed the title If Explorer file sorting is set to "modified" it sorts files and not folders but only for Github repositories extension (virtual workspaces) If Explorer file sorting is set to "modified", sorting only shows corect for uncommited files by modified date. Sorting is displayed incorrectly in aphabetical order for folders or commited files Dec 30, 2023
@devgid devgid changed the title If Explorer file sorting is set to "modified", sorting only shows corect for uncommited files by modified date. Sorting is displayed incorrectly in aphabetical order for folders or commited files If Explorer file sorting is set to "modified", sorting only shows corect for uncommited files by modified date. Sorting is displayed incorrectly in aphabetical order for folders and commited files Dec 30, 2023
@devgid devgid changed the title If Explorer file sorting is set to "modified", sorting only shows corect for uncommited files by modified date. Sorting is displayed incorrectly in aphabetical order for folders and commited files If Explorer file sorting is set to "modified", sorting only shows correct for uncommited files by modified date. Sorting is displayed incorrectly in alphabetical order for folders and commited files Dec 30, 2023
@joyceerhl joyceerhl self-assigned this Jan 3, 2024
@joyceerhl joyceerhl added the bug Issue identified by VS Code Team member as probable bug label Jan 3, 2024
@joyceerhl joyceerhl added this to the Backlog milestone Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Development

No branches or pull requests

2 participants