Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No warning/error when pasting broken links into the Open Remote Repository quick pick #347

Open
rebornix opened this issue Jul 10, 2023 · 5 comments
Assignees
Labels
feature-request Request for new features or functionality polish
Milestone

Comments

@rebornix
Copy link
Member

  • Run Open Remote Repository from the remote picker
  • Paste in an invalid url (/dev/microsoft/vscode)
  • Press enter, nothing happens

It should probably show a warning in the quick pick (through quick pick validation message) instead of doing nothing.

@joyceerhl
Copy link
Contributor

Is the validation message exposed for quickpicks? I thought it was only available as API for input box: https://github.com/microsoft/vscode/blob/16e948e102faa324bc263ed31463ad0a95f2250c/src/vscode-dts/vscode.d.ts#L11704-L11709

@rebornix
Copy link
Member Author

@joyceerhl ah you might need to use the InputBox API instead of the QuickPick shortcut to archive this

@joyceerhl
Copy link
Contributor

But then we wouldn't be able to provide options for the user to choose from 🤔

@joyceerhl
Copy link
Contributor

Maybe this is just a feature request to support validation messages for the quickpick API?

@joyceerhl joyceerhl self-assigned this Jul 10, 2023
@joyceerhl joyceerhl added feature-request Request for new features or functionality polish labels Jul 10, 2023
@joyceerhl joyceerhl added this to the Backlog milestone Jul 10, 2023
@TylerLeonhardt
Copy link
Member

TylerLeonhardt commented Jul 10, 2023

Could an item with the contents:

Invalid url: ${quickpick.value}

Be sufficient? Details of that error could be in the description/detail of quick pick item.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality polish
Projects
None yet
Development

No branches or pull requests

3 participants