Update to clang-tidy 21. (#13946)

Author: sean-mcmanus

Extension/package.json

@@ -1901,6 +1901,7 @@
                                 "bugprone-bitwise-pointer-cast",
                                 "bugprone-bool-pointer-implicit-conversion",
                                 "bugprone-branch-clone",
+                                "bugprone-capturing-this-in-member-variable",
                                 "bugprone-casting-through-void",
                                 "bugprone-chained-comparison",
                                 "bugprone-compare-pointer-to-member-virtual-function",
@@ -1926,6 +1927,7 @@
                                 "bugprone-lambda-function-name",
                                 "bugprone-macro-parentheses",
                                 "bugprone-macro-repeated-side-effects",
+                                "bugprone-misleading-setter-of-reference",
                                 "bugprone-misplaced-*",
                                 "bugprone-misplaced-operator-in-strlen-in-alloc",
                                 "bugprone-misplaced-pointer-arithmetic-in-alloc",
@@ -1982,6 +1984,7 @@
                                 "bugprone-unhandled-*",
                                 "bugprone-unhandled-exception-at-new",
                                 "bugprone-unhandled-self-assignment",
+                                "bugprone-unintended-char-ostream-output",
                                 "bugprone-unique-ptr-array-mismatch",
                                 "bugprone-unsafe-functions",
                                 "bugprone-unused-*",
@@ -2208,6 +2211,8 @@
                                 "cppcoreguidelines-rvalue-reference-param-not-moved",
                                 "cppcoreguidelines-slicing",
                                 "cppcoreguidelines-special-member-functions",
+                                "cppcoreguidelines-use-*",
+                                "cppcoreguidelines-use-enum-class",
                                 "cppcoreguidelines-use-default-member-init",
                                 "cppcoreguidelines-virtual-class-destructor",
                                 "darwin-*",
@@ -2293,6 +2298,7 @@
                                 "llvm-prefer-*",
                                 "llvm-prefer-isa-or-dyn-cast-in-conditionals",
                                 "llvm-prefer-register-over-unsigned",
+                                "llvm-prefer-static-over-anonymous-namespace",
                                 "llvm-qualified-auto",
                                 "llvm-twine-local",
                                 "llvmlibc-*",
@@ -2370,6 +2376,7 @@
                                 "modernize-use-nullptr",
                                 "modernize-use-override",
                                 "modernize-use-ranges",
+                                "modernize-use-scoped-lock",
                                 "modernize-use-starts-ends-with",
                                 "modernize-use-std-*",
                                 "modernize-use-std-format",
@@ -2421,11 +2428,13 @@
                                 "performance-unnecessary-copy-initialization",
                                 "performance-unnecessary-value-param",
                                 "portability-*",
+                                "portability-avoid-pragma-once",
                                 "portability-restrict-system-includes",
                                 "portability-simd-intrinsics",
                                 "portability-std-allocator-const",
                                 "portability-template-virtual-member-function",
                                 "readability-*",
+                                "readability-ambiguous-smartptr-reset-call",
                                 "readability-avoid-*",
                                 "readability-avoid-const-params-in-decls",
                                 "readability-avoid-nested-conditional-operator",
@@ -2486,6 +2495,7 @@
                                 "readability-uppercase-literal-suffix",
                                 "readability-use-*",
                                 "readability-use-anyofallof",
+                                "readability-use-concise-preprocessor-directives",
                                 "readability-use-std-min-max",
                                 "zircon-temporary-objects"
                             ]
@@ -2561,6 +2571,7 @@
                                 "bugprone-bitwise-pointer-cast",
                                 "bugprone-bool-pointer-implicit-conversion",
                                 "bugprone-branch-clone",
+                                "bugprone-capturing-this-in-member-variable",
                                 "bugprone-casting-through-void",
                                 "bugprone-chained-comparison",
                                 "bugprone-compare-pointer-to-member-virtual-function",
@@ -2586,6 +2597,7 @@
                                 "bugprone-lambda-function-name",
                                 "bugprone-macro-parentheses",
                                 "bugprone-macro-repeated-side-effects",
+                                "bugprone-misleading-setter-of-reference",
                                 "bugprone-misplaced-*",
                                 "bugprone-misplaced-operator-in-strlen-in-alloc",
                                 "bugprone-misplaced-pointer-arithmetic-in-alloc",
@@ -2642,6 +2654,7 @@
                                 "bugprone-unhandled-*",
                                 "bugprone-unhandled-exception-at-new",
                                 "bugprone-unhandled-self-assignment",
+                                "bugprone-unintended-char-ostream-output",
                                 "bugprone-unique-ptr-array-mismatch",
                                 "bugprone-unsafe-functions",
                                 "bugprone-unused-*",
@@ -2868,6 +2881,8 @@
                                 "cppcoreguidelines-rvalue-reference-param-not-moved",
                                 "cppcoreguidelines-slicing",
                                 "cppcoreguidelines-special-member-functions",
+                                "cppcoreguidelines-use-*",
+                                "cppcoreguidelines-use-enum-class",
                                 "cppcoreguidelines-use-default-member-init",
                                 "cppcoreguidelines-virtual-class-destructor",
                                 "darwin-*",
@@ -2953,6 +2968,7 @@
                                 "llvm-prefer-*",
                                 "llvm-prefer-isa-or-dyn-cast-in-conditionals",
                                 "llvm-prefer-register-over-unsigned",
+                                "llvm-prefer-static-over-anonymous-namespace",
                                 "llvm-qualified-auto",
                                 "llvm-twine-local",
                                 "llvmlibc-*",
@@ -3030,6 +3046,7 @@
                                 "modernize-use-nullptr",
                                 "modernize-use-override",
                                 "modernize-use-ranges",
+                                "modernize-use-scoped-lock",
                                 "modernize-use-starts-ends-with",
                                 "modernize-use-std-*",
                                 "modernize-use-std-format",
@@ -3081,11 +3098,13 @@
                                 "performance-unnecessary-copy-initialization",
                                 "performance-unnecessary-value-param",
                                 "portability-*",
+                                "portability-avoid-pragma-once",
                                 "portability-restrict-system-includes",
                                 "portability-simd-intrinsics",
                                 "portability-std-allocator-const",
                                 "portability-template-virtual-member-function",
                                 "readability-*",
+                                "readability-ambiguous-smartptr-reset-call",
                                 "readability-avoid-*",
                                 "readability-avoid-const-params-in-decls",
                                 "readability-avoid-nested-conditional-operator",
@@ -3146,6 +3165,7 @@
                                 "readability-uppercase-literal-suffix",
                                 "readability-use-*",
                                 "readability-use-anyofallof",
+                                "readability-use-concise-preprocessor-directives",
                                 "readability-use-std-min-max",
                                 "zircon-temporary-objects"
                             ]

Extension/src/LanguageServer/codeAnalysis.ts

@@ -379,7 +379,7 @@ export function publishCodeAnalysisDiagnostics(params: PublishCodeAnalysisDiagno
                     docPage = `checks${checksGroup}/${checksPage}.html`;
                 }
                 // TODO: This should be checking the clang-tidy version used to better support usage of older versions.
-                const primaryDocUri: vscode.Uri = vscode.Uri.parse(`https://releases.llvm.org/20.1.0/tools/clang/tools/extra/docs/clang-tidy/${docPage}`);
+                const primaryDocUri: vscode.Uri = vscode.Uri.parse(`https://releases.llvm.org/21.1.0/tools/clang/tools/extra/docs/clang-tidy/${docPage}`);
                 diagnostic.code = { value: identifier.code, target: primaryDocUri };
 
                 if (new CppSettings().clangTidyCodeActionShowDocumentation) {