[boost] update to 1.91.0#51397
Conversation
|
Looks like all platforms are failing due to a downstream break in |
still 11 ports depend on static_assert, contract, date-time, geometry, graph, icl, program-options, python, serialization, spirit, variant, wave
Mark boost[core], boost-graph-parallel, boost-parameter-python, boost-property-map-parallel, boost-python as passing on arm64-linux (was cascade). Mark boost-math[legacy] as expected failure on x64-android.
|
x64-android related errors: boostorg/math#1390 |
|
Boost.Math #1390 has been merged. |
|
the x84-windows errors: vxl sleef |
Add scripts\boost\patch-stubs\math.txt and scripts\boost\pre-source-stubs\math.cmake to avoid meaningful changes to boost-math. Rerun generate-ports.ps1 , which removed boost-static-assert from dependencies of most ports. Actually deindex boost-static-assert. Update dependent ports autodock-vina, cctag, coin, and pfultz2-linq to depend on boost-config instead.
|
Unfortunately when I rerun generate-ports.ps1 that results in edits here. Also, it looks like the generate-ports scripts does not really handle the removal of boost-static-assert correctly on its own, so we should deindex it manually. I fixed both of those in miyanyan#2 . Unfortunately it looks like our "check for common mistakes" check tries to stop mutating versions in PRs against PRs like this... |
BillyONeal
left a comment
There was a problem hiding this comment.
(See above comment and miyanyan#2 )
Fix generate-ports.ps1 + complete boost-static-assert removal.
|
@BillyONeal totally remove static_assert will cause cmake config errors, as 1.91.0 release said, static_assert is still exists I added static_assert to the dependency list for these ports in generate-ports.ps1 so their generated vcpkg.json includes boost-static-assert: And I rerun the generate-ports.ps1 that results in no edits here. |
|
I thought Boost.Config would provide that CMake target based on the "merged into Config" statement in the release announcement. If it still exists as a separate package I apologize for the confusion. |
./vcpkg x-add-version --alland committing the result.Fixes #51326
https://www.boost.org/releases/1.91.0/