Skip to content

Commit 9e50bd5

Browse files
bfjeldsCopilot
andcommitted
make: note COSI vs baremetal-image ambiguity on .cosi targets
The pattern rule passes the file extension as --output-type, so a .cosi target always resolves to OutputFormat.COSI even for configs that intend OutputFormat.BAREMETAL_IMAGE (both use extension cosi). Echo a note on .cosi builds pointing users who want a baremetal-image COSI to invoke testimages.py directly with --output-type baremetal-image. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent 175cdc7 commit 9e50bd5

1 file changed

Lines changed: 1 addition & 0 deletions

File tree

Makefile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -950,6 +950,7 @@ validate-pipeline-website-artifact:
950950
artifacts/%.cosi artifacts/%.iso artifacts/%.vhdx artifacts/%.vhd artifacts/%.qcow2: $$(shell ./tests/images/testimages.py dependencies $$*)
951951
@echo "Building '$*' [$@] from $<"
952952
@echo "Extension is: $(subst .,,$(suffix $@))"
953+
@test "$(subst .,,$(suffix $@))" != "cosi" || echo "NOTE: customizing a COSI image (OutputFormat.COSI). If you intend a baremetal-image COSI (OutputFormat.BAREMETAL_IMAGE), invoke ./tests/images/testimages.py build $* --output-type baremetal-image directly."
953954
@echo "Prerequisites:"
954955
@echo "$^" | tr ' ' '\n' | sed 's/^/ /'
955956
@echo "Building image..."

0 commit comments

Comments
 (0)