Fix multiple regressions since #18215 #18345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhecker
changed the title
microsoft-github-policy-service
bot
added
Issue-Bug
DHowett
approved these changes
Dec 22, 2024
| const auto hwnd = msg.hwnd; | ||
| AppHost* window = nullptr; | ||
|
|
||
| // Just in case someone has targed a specific HWND, |
There was a problem hiding this comment.
targeted
Suggested change
| // Just in case someone has targed a specific HWND, | |
| // Just in case someone has targeted a specific HWND, |
k-jeznach
reviewed
Jan 2, 2025
| // ENDSESSION_CLOSEAPP: The application is using a file that must be replaced, | ||
| // the system is being serviced, or system resources are exhausted. | ||
| RegisterApplicationRestart(nullptr, RESTART_NO_CRASH | RESTART_NO_HANG); | ||
| return TRUE; |
There was a problem hiding this comment.
Wouldn't it be better for code consistency to write return 1, or possibly adjust the rest of the method code to use return FALSE instead?
There was a problem hiding this comment.
FWIW I did it this way because the documentation for this message uses TRUE and FALSE.
carlos-zamora
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
CoreWindow::GetForCurrentThread().PointerCursor()WM_ACTIVATEmessage now arrives before theAppHostis initialized.This caused the messages to be delivered to old windows.
because we return
FALSEon non-ENDSESSION_CLOSEAPPmessages.Closes #18331
Closes #18335
Validation Steps Performed