-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sidebar and settings are shown at the same time #16906
Comments
Huh, we saw this before in #9337 which should have been fixed in #9752, back in 1.8. Though, it seems like those resources got lost some time ago: https://github.com/microsoft/terminal/blob/main/src/cascadia/TerminalSettingsEditor/MainPage.xaml Oh dear it was lost in #12973 |
That's odd, I'm unable to reproduce this issue. Might this be a Win 10 issue maybe? |
Hey @marcelwgn @zadjii-msft , I was able to reproduce it on my W10 machine with the version of the terminal 1.19.10573.0. I followed the same steps as mentioned in the description. If possible, I would like to investigate this issue a little bit more |
@marcelwgn, apologies for the delayed update. The concept suggested by @zadjii-msft in #9752 is the root cause of the issue addressed by the changes implemented in #9752. These changes enable the modification of the panel's color when it's not being rendered (using |
I'd honestly just revert back to the acrylic brush with a fallback color set. This is so wacky when it does happen, that literally anything would be better than this 😅 |
@zadjii-msft Sure, I will do that today, and I will submit the PR. Thanks for the feedback 😄 |
@zadjii-msft @marcelwgn PR opened 😄 |
Windows Terminal version
1.19.10573.0
Windows build number
10.0.19045.3930
Other Software
No response
Steps to reproduce
Expected Behavior
Actual Behavior
There is no overlaying text over the settings and the sidebar is hidden.
The text was updated successfully, but these errors were encountered: