Skip to content

Commit 20bdc21

Browse files
committed
clean up more TODOs
1 parent a4c69cf commit 20bdc21

File tree

2 files changed

+2
-5
lines changed

2 files changed

+2
-5
lines changed

src/cascadia/TerminalSettingsEditor/MainPage.cpp

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -212,8 +212,8 @@ namespace winrt::Microsoft::Terminal::Settings::Editor::implementation
212212
else if (const auto stringNavArg = navigationArg.try_as<hstring>())
213213
{
214214
// The hstring navArg can be...
215-
// - a color scheme name
216-
// - an hstring tag (all defined at the top of the file)
215+
// - color scheme name
216+
// - hstring tag (all defined at the top of the file)
217217
// Regardless, we'll use the font icon used by the navigation view item
218218
WUX::Controls::FontIcon icon{};
219219
icon.FontFamily(Media::FontFamily{ L"Segoe Fluent Icons, Segoe MDL2 Assets" });
@@ -1439,7 +1439,6 @@ namespace winrt::Microsoft::Terminal::Settings::Editor::implementation
14391439
filteredIndex.clear();
14401440
for (const auto& entry : searchIndex)
14411441
{
1442-
// TODO CARLOS: replace with fuzzy search
14431442
// Check for a match with DisplayText (i.e. "Globals_DefaultProfile/Header") and HelpText (i.e. "Globals_DefaultProfile/HelpText")
14441443
// in language neutral and current language
14451444
if (til::contains_linguistic_insensitive(entry.Entry->DisplayTextLocalized, queryText) ||

src/cascadia/TerminalSettingsEditor/Utils.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -137,8 +137,6 @@ struct HasScrollViewer
137137
// or else the call to StartBringIntoView()
138138
// will end up doing nothing
139139
controlToFocus.StartBringIntoView();
140-
141-
// TODO CARLOS: ensure this works in all scenarios (easiest to test when navigating to page by keyboard)
142140
controlToFocus.Focus(winrt::Windows::UI::Xaml::FocusState::Programmatic);
143141
}
144142
page->_loadedRevoker.revoke();

0 commit comments

Comments
 (0)