-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add kernel version to telemetry traces. #1071
Comments
Hi @jimassa, I would like to contribute to this |
Hello @jimassa I have made the necessary changes and committed a PR. Kindly review it. Thank you. |
isn't it possible to correlate pod name with kernel version in heartbeat? |
Thank you for the suggestion! I will add the pod name to the heartbeat properties to enable correlation with the kernel version. I'll update the PR shortly. Please let me know if there are any other changes/features to be implemented. |
podname should already be a part of telemetry properties, so it should be all good retina/pkg/telemetry/telemetry.go Line 155 in 8963dd5
|
Yes, In the TrackEvent method, t.properties is merged with the provided event properties, so podname will automatically be included in the heartbeat telemetry. |
heartbeat already comes with kernel version attribute;
retina/pkg/telemetry/telemetry.go
Line 170 in 5ff1567
We would like to add it to traces as well in order to directly pinpoint what kernel version is producing a specific log.
The text was updated successfully, but these errors were encountered: