Modern Inspector Outstanding Issues

[vmoroz]

Modern Inspector Outstanding Issues

Follow-ups from PR #15328 (Add support for modern inspector)

• Implement the NetworkIOAgent pathway so the modern inspector can fetch network resources on Windows (ReactInspectorHostTargetDelegate::loadNetworkResource in vnext/Microsoft.ReactNative/ReactHost/ReactHost.cpp). Source: PR description and docs/modern-inspector-details.md.(This will taken up in 0.82 Implement the NetworkIOAgent pathway for fusebox arch in windows #15369 )
• Enrich the host target metadata that we expose to the inspector (reuse the app identity and current debugger naming instead of the placeholder string). Tracked in review thread Add support for modern inspector #15328 (comment) and issue Improve the page name that shows up in the debugger's page/target list #15342. (Done in PR Improve the inspector page name for modern debugger #15375)
• Replace the temporary inspector page name ("React Native Windows (Experimental)") with the final identity we want to surface in DevTools. Tracked in review thread Add support for modern inspector #15328 (comment) and issue Improve the page name that shows up in the debugger's page/target list #15342. (Done in PR Improve the inspector page name for modern debugger #15375)
• Decide whether DevSupportManager::OpenDevTools should remain and, if so, wire it up to the active dev server configuration instead of the baked-in localhost:8081 default (vnext/Shared/DevSupportManager.cpp). (Removed in PR Debugger outstanding issues #15392)
• Extract the variadic string_format helper out of DevServerHelper (or replace it) so we stop hand-rolling snprintf plumbing (vnext/Shared/DevServerHelper.h). (Done in PR Debugger outstanding issues #15392 - we must avoid copy by using std::stirng directly instead of unique_ptr)
• Track modern inspector parity for Chakra-based runtimes (Chakra still falls back to legacy debugging). Source: docs/modern-inspector-details.md. We removed Chakra support from main.
• Provide the real process ID to the RuntimeSamplingProfile constructor in HermesRuntimeTargetDelegate.cpp (Done in PR Debugger outstanding issues #15392)
• Remove support for the old sampling profiler and all the related Hermes wiring for it. The old profiler was added in PR Fix Hermes sampling profiler #11033. We must see if any of that code is still around and if yes, then we should delete it.(Done in PR Debugger outstanding issues #15392)
• See if the debugger paused overlay and the debugger component overlay work correctly with font size 150%.

Follow-ups noted in prototype PR #13008 (Wire up Fusebox in react-native-windows)

• Defer inspector setup in ReactNativeHost until the first instance reload so feature flags can be toggled after host construction (comment: Wire up Fusebox in react-native-windows #13008 (comment)). (It was done in the original PR Add support for modern inspector #15328)
• Fix the debugger paused flyout dismissing itself when the app window is resized (comment: Wire up Fusebox in react-native-windows #13008 (comment)). (@vmoroz: This comment was done against paper we should check if Fabric is OK)
• Relocate the Ctrl+Shift+I dev tools shortcut wiring to a non-hacky location that can see both DevSettings and all active XamlRoots (comment: Wire up Fusebox in react-native-windows #13008 (comment)).
• Revisit the dedicated inspector serial queue to confirm we tear everything down safely; we may need additional lifetime management (comment: Wire up Fusebox in react-native-windows #13008 (comment)). (@vmoroz: it seems to be OK for now)