Fix Flow check for macos (#212)

* Initial changes for macos flow check

* Fixed all macos flow errors

* Cleaned up AccessibiltInfo stub

* Cleanup

* Added diff comments

Author: tom-un

.ado/templates/apple-job-javascript.yml

@@ -13,8 +13,14 @@ steps:
   - script: 'yarn test-ci'
     displayName: 'yarn test-ci'
 
-  - script: 'yarn flow'
-    displayName: 'yarn flow'
+  - script: 'yarn flow-check-ios'
+    displayName: 'yarn flow-check-ios'
+
+  - script: 'yarn flow-check-macos'
+    displayName: 'yarn flow-check-macos'
+
+  - script: 'yarn flow-check-android'
+    displayName: 'yarn flow-check-android'
 
   - script: 'yarn lint'
     displayName: 'yarn lint'

.flowconfig

@@ -1,6 +1,8 @@
 [ignore]
 ; We fork some components by platform
 .*/*[.]android.js
+; TODO(macOS ISS#2323203):
+.*/*[.]macos.js
 
 ; Ignore templates for 'react-native init'
 <PROJECT_ROOT>/template/.*
@@ -60,6 +62,8 @@ module.system.haste.name_reducers='^.*/\([a-zA-Z0-9$_.-]+\.js\(\.flow\)?\)$' ->
 module.system.haste.name_reducers='^\(.*\)\.js\(\.flow\)?$' -> '\1'
 # strip .ios suffix
 module.system.haste.name_reducers='^\(.*\)\.ios$' -> '\1'
+# TODO(macOS ISS#2323203):
+module.system.haste.name_reducers='^\(.*\)\.macos$' -> '\1'
 module.system.haste.name_reducers='^\(.*\)\.android$' -> '\1'
 module.system.haste.name_reducers='^\(.*\)\.native$' -> '\1'
 module.system.haste.paths.blacklist=.*/__tests__/.*

.flowconfig.android

@@ -1,6 +1,7 @@
 [ignore]
 ; We fork some components by platform
 .*/*[.]ios.js
+; TODO(macOS ISS#2323203):
 .*/*[.]macos.js
 
 ; Ignore templates for 'react-native init'
@@ -23,6 +24,9 @@
 ; Ignore polyfills
 .*/Libraries/polyfills/.*
 
+; TODO(macOS ISS#2323203): Ignore metro.config.js
+<PROJECT_ROOT>/metro.config.js
+
 ; Ignore files that have a base platform file and an android file
 <PROJECT_ROOT>/Libraries/Image/Image.js
 <PROJECT_ROOT>/Libraries/Network/RCTNetworking.js
@@ -68,6 +72,8 @@ module.system.haste.name_reducers='^\(.*\)\.js\(\.flow\)?$' -> '\1'
 # strip .android suffix
 module.system.haste.name_reducers='^\(.*\)\.android$' -> '\1'
 module.system.haste.name_reducers='^\(.*\)\.ios$' -> '\1'
+# TODO(macOS ISS#2323203):
+module.system.haste.name_reducers='^\(.*\)\.macos$' -> '\1'
 module.system.haste.name_reducers='^\(.*\)\.native$' -> '\1'
 module.system.haste.paths.blacklist=.*/__tests__/.*
 module.system.haste.paths.blacklist=.*/__mocks__/.*

.flowconfig.macos

@@ -0,0 +1,112 @@
+[ignore]
+; TODO(macOS ISS#2323203)
+; We fork some components by platform
+.*/*[.]ios.js
+.*/*[.]android.js
+
+; Ignore templates for 'react-native init'
+<PROJECT_ROOT>/template/.*
+
+; Ignore the Dangerfile
+<PROJECT_ROOT>/bots/dangerfile.js
+
+; Ignore "BUCK" generated dirs
+<PROJECT_ROOT>/\.buckd/
+
+; Ignore unexpected extra "@providesModule"
+.*/node_modules/.*/node_modules/fbjs/.*
+
+; Ignore duplicate module providers
+; For RN Apps installed via npm, "Libraries" folder is inside
+; "node_modules/react-native" but in the source repo it is in the root
+.*/Libraries/react-native/React.js
+
+; Ignore polyfills
+.*/Libraries/polyfills/.*
+
+; Ignore metro.config.js
+<PROJECT_ROOT>/metro.config.js
+
+; These should not be required directly
+; require from fbjs/lib instead: require('fbjs/lib/warning')
+.*/node_modules/warning/.*
+
+; Flow doesn't support platforms
+.*/Libraries/Utilities/HMRLoadingView.js
+
+[untyped]
+.*/node_modules/@react-native-community/cli/.*/.*
+
+[include]
+
+[libs]
+Libraries/react-native/react-native-interface.js
+flow/
+
+[options]
+emoji=true
+
+esproposal.optional_chaining=enable
+esproposal.nullish_coalescing=enable
+
+module.file_ext=.js
+module.file_ext=.json
+module.file_ext=.macos.js
+
+module.system=haste
+module.system.haste.use_name_reducers=true
+# keep the following in sync with server/haste/hasteImpl.js
+# get basename
+module.system.haste.name_reducers='^.*/\([a-zA-Z0-9$_.-]+\.js\(\.flow\)?\)$' -> '\1'
+# strip .js or .js.flow suffix
+module.system.haste.name_reducers='^\(.*\)\.js\(\.flow\)?$' -> '\1'
+# strip .macos suffix
+module.system.haste.name_reducers='^\(.*\)\.macos$' -> '\1'
+module.system.haste.name_reducers='^\(.*\)\.ios$' -> '\1'
+module.system.haste.name_reducers='^\(.*\)\.android$' -> '\1'
+module.system.haste.name_reducers='^\(.*\)\.native$' -> '\1'
+module.system.haste.paths.blacklist=.*/__tests__/.*
+module.system.haste.paths.blacklist=.*/__mocks__/.*
+module.system.haste.paths.whitelist=<PROJECT_ROOT>/Libraries/.*
+module.system.haste.paths.whitelist=<PROJECT_ROOT>/RNTester/.*
+module.system.haste.paths.whitelist=<PROJECT_ROOT>/IntegrationTests/.*
+module.system.haste.paths.blacklist=<PROJECT_ROOT>/Libraries/react-native/react-native-implementation.js
+module.system.haste.paths.blacklist=<PROJECT_ROOT>/Libraries/Animated/src/polyfills/.*
+
+munge_underscores=true
+
+module.name_mapper='^[./a-zA-Z0-9$_-]+\.\(bmp\|gif\|jpg\|jpeg\|png\|psd\|svg\|webp\|m4v\|mov\|mp4\|mpeg\|mpg\|webm\|aac\|aiff\|caf\|m4a\|mp3\|wav\|html\|pdf\)$' -> 'RelativeImageStub'
+
+suppress_type=$FlowIssue
+suppress_type=$FlowFixMe
+suppress_type=$FlowFixMeProps
+suppress_type=$FlowFixMeState
+
+suppress_comment=\\(.\\|\n\\)*\\$FlowFixMe\\($\\|[^(]\\|(\\(<VERSION>\\)? *\\(site=[a-z,_]*react_native\\(_ios\\)?_\\(oss\\|fb\\)[a-z,_]*\\)?)\\)
+suppress_comment=\\(.\\|\n\\)*\\$FlowIssue\\((\\(<VERSION>\\)? *\\(site=[a-z,_]*react_native\\(_ios\\)?_\\(oss\\|fb\\)[a-z,_]*\\)?)\\)?:? #[0-9]+
+suppress_comment=\\(.\\|\n\\)*\\$FlowExpectedError
+
+[lints]
+sketchy-null-number=warn
+sketchy-null-mixed=warn
+sketchy-number=warn
+untyped-type-import=warn
+nonstrict-import=warn
+deprecated-type=warn
+unsafe-getters-setters=warn
+inexact-spread=warn
+unnecessary-invariant=warn
+signature-verification-failure=warn
+deprecated-utility=error
+
+[strict]
+deprecated-type
+nonstrict-import
+sketchy-null
+unclear-type
+unsafe-getters-setters
+untyped-import
+untyped-type-import
+
+[version]
+^0.98.0

Libraries/Components/AccessibilityInfo/AccessibilityInfo.macos.js

@@ -0,0 +1,104 @@
+/**
+ * Copyright (c) Facebook, Inc. and its affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ *
+ * @format
+ * @flow
+ */
+
+// TODO(macOS ISS#2323203)
+
+'use strict';
+
+const warning = require('fbjs/lib/warning');
+
+type ChangeEventName = $Keys<{}>;
+
+const AccessibilityInfo = {
+  /**
+   * iOS only
+   */
+  isBoldTextEnabled: function(): Promise<boolean> {
+    return Promise.resolve(false);
+  },
+
+  /**
+   * iOS only
+   */
+  isGrayscaleEnabled: function(): Promise<boolean> {
+    return Promise.resolve(false);
+  },
+
+  /**
+   * iOS only
+   */
+  isInvertColorsEnabled: function(): Promise<boolean> {
+    return Promise.resolve(false);
+  },
+
+  /**
+   * Android and iOS only
+   */
+  isReduceMotionEnabled: function(): Promise<boolean> {
+    return Promise.resolve(false);
+  },
+
+  /**
+   * iOS only
+   */
+  isReduceTransparencyEnabled: function(): Promise<boolean> {
+    return Promise.resolve(false);
+  },
+
+  /**
+   * Android and iOS only
+   */
+  isScreenReaderEnabled: function(): Promise<boolean> {
+    return Promise.resolve(false);
+  },
+
+  /**
+   * Deprecated
+   *
+   * Same as `isScreenReaderEnabled`
+   */
+  get fetch() {
+    return this.isScreenReaderEnabled;
+  },
+
+  addEventListener: function(
+    eventName: ChangeEventName,
+    handler: Function,
+  ): void {
+    warning(false, 'AccessibilityInfo is not supported on this platform.');
+  },
+
+  removeEventListener: function(
+    eventName: ChangeEventName,
+    handler: Function,
+  ): void {
+    warning(false, 'AccessibilityInfo is not supported on this platform.');
+  },
+
+  /**
+   * Set accessibility focus to a react component.
+   *
+   * See http://facebook.github.io/react-native/docs/accessibilityinfo.html#setaccessibilityfocus
+   */
+  setAccessibilityFocus: function(reactTag: number): void {
+    warning(false, 'AccessibilityInfo is not supported on this platform.');
+  },
+
+  /**
+   * Post a string to be announced by the screen reader.
+   *
+   * See http://facebook.github.io/react-native/docs/accessibilityinfo.html#announceforaccessibility
+   */
+  announceForAccessibility: function(announcement: string): void {
+    warning(false, 'AccessibilityInfo is not supported on this platform.');
+  },
+};
+
+module.exports = AccessibilityInfo;

Libraries/Components/SafeAreaView/SafeAreaView.macos.js renamed to Libraries/Components/DrawerAndroid/DrawerLayoutAndroid.macos.js

@@ -1,15 +1,14 @@
 /**
- * Copyright (c) 2015-present, Facebook, Inc.
+ * Copyright (c) Facebook, Inc. and its affiliates.
  *
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  *
- * @flow
  * @format
  */
 
 // TODO(macOS ISS#2323203)
 
 'use strict';
 
-module.exports = require('View');
+module.exports = require('../UnimplementedViews/UnimplementedView');

Libraries/Components/Picker/PickerIOS.macos.js

@@ -8,7 +8,6 @@
  * This is a controlled component version of RCTPickerIOS
  *
  * @format
- * @flow
  */
 
 // TODO(macOS ISS#2323203)

Libraries/Components/SafeAreaView/SafeAreaView.js

@@ -31,7 +31,8 @@ let exported;
  * limitation of the screen, such as rounded corners or camera notches (aka
  * sensor housing area on iPhone X).
  */
-if (Platform.OS === 'android') {
+if (Platform.OS !== 'ios') {
+  // TODO(macOS ISS#2323203)
   const SafeAreaView = (
     props: Props,
     forwardedRef?: ?React.Ref<typeof View>,

Libraries/Components/StatusBar/StatusBarIOS.macos.js

@@ -0,0 +1,23 @@
+/**
+ * Copyright (c) Facebook, Inc. and its affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ *
+ * @format
+ * @flow strict-local
+ */
+
+// TODO(macOS ISS#2323203)
+
+'use strict';
+
+const NativeEventEmitter = require('../../EventEmitter/NativeEventEmitter');
+const {StatusBarManager} = require('../../BatchedBridge/NativeModules');
+
+/**
+ * Use `StatusBar` for mutating the status bar.
+ */
+class StatusBarIOS extends NativeEventEmitter {}
+
+module.exports = new StatusBarIOS(StatusBarManager);

Libraries/Components/TimePickerAndroid/TimePickerAndroid.macos.js

@@ -0,0 +1,28 @@
+/**
+ * Copyright (c) Facebook, Inc. and its affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ *
+ * @format
+ * @flow strict-local
+ */
+
+// TODO(macOS ISS#2323203)
+
+'use strict';
+
+import type {
+  TimePickerOptions,
+  TimePickerResult,
+} from './TimePickerAndroidTypes';
+
+const TimePickerAndroid = {
+  async open(options: TimePickerOptions): Promise<TimePickerResult> {
+    return Promise.reject({
+      message: 'TimePickerAndroid is not supported on this platform.',
+    });
+  },
+};
+
+module.exports = TimePickerAndroid;