Update react-native PR build pipeline to use macOS Mojave agents and XCode 11 beta (#153)

* Switch to XCode 11.

* All tests passing

* Update node to 10

* Update yaml scripts to use the Mojave agent pools

* Fixed ado-test-setup.sh script

* Fix build error for RNTesterBundle-macOS

* fixed shellcheck issues

Author: tom-un

.ado/ado-test-cleanup.sh

@@ -9,17 +9,18 @@ lsof -i tcp:8081 | awk 'NR!=1 {print $2}' | xargs kill
 # kill whatever is occupying port 5555 (web socket server)
 lsof -i tcp:5555 | awk 'NR!=1 {print $2}' | xargs kill
 
-osascript <<'EOF'
-tell application "Terminal"
-  set winlist to windows where name contains "React Packager" or name contains "Metro Bundler" or name contains "Web Socket Test Server"
-  repeat with win in winlist
-    tell application "Terminal" to close win
-  end repeat
-end tell
-EOF
+# AppleScript can't be invoked from Azure DevOps Mojave agents until the following ticket is resolved: https://dev.azure.com/mseng/AzureDevOps/_workitems/edit/1513729
+# osascript <<'EOF'
+# tell application "Terminal"
+#   set winlist to windows where name contains "React Packager" or name contains "Metro Bundler" or name contains "Web Socket Test Server"
+#   repeat with win in winlist
+#     tell application "Terminal" to close win
+#   end repeat
+# end tell
+# EOF
 
 # clear packager cache
-rm -fr $TMPDIR/react-*
+rm -fr "$TMPDIR/react-*"
 
 # clear watchman state
 rm -rf /usr/local/var/run/watchman/*

.ado/ado-test-setup.sh

@@ -5,8 +5,20 @@ set -ex
 
 THIS_DIR=$PWD
 
+# AppleScript can't be invoked from Azure DevOps Mojave agents until the following ticket is resolved: https://dev.azure.com/mseng/AzureDevOps/_workitems/edit/1513729
+
 # Start the packager
-osascript -e "tell application \"Terminal\" to do script \"cd ${THIS_DIR}; export SERVERS_NO_WAIT=1; ./scripts/launchPackager.command --reactNativePath ${THIS_DIR}\""
+# osascript -e "tell application \"Terminal\" to do script \"cd ${THIS_DIR}; export SERVERS_NO_WAIT=1; ./scripts/launchPackager.command --reactNativePath ${THIS_DIR}\""
 
 # Start the WebSocket test server
-osascript -e "tell application \"Terminal\" to do script \"cd ${THIS_DIR}; export SERVERS_NO_WAIT=1; ./IntegrationTests/launchWebSocketServer.command\""
+# osascript -e "tell application \"Terminal\" to do script \"cd ${THIS_DIR}; export SERVERS_NO_WAIT=1; ./IntegrationTests/launchWebSocketServer.command\""
+
+COMMAND="$TMPDIR/launchPackager.command"
+echo "cd ${THIS_DIR}; export SERVERS_NO_WAIT=1; ./scripts/launchPackager.command --reactNativePath ${THIS_DIR}" > "$COMMAND"
+chmod +x "$COMMAND"
+open "$COMMAND"
+
+COMMAND="$TMPDIR/launchWebSocketServer.command"
+echo "cd ${THIS_DIR}; export SERVERS_NO_WAIT=1; ./IntegrationTests/launchWebSocketServer.command" > "$COMMAND"
+chmod +x "$COMMAND"
+open "$COMMAND"

.ado/apple-pr.yml

@@ -15,7 +15,7 @@ jobs:
           packager_platform: 'ios'
           xcode_sdk: iphonesimulator
           xcode_scheme: 'RNTester'
-          xcode_destination: 'platform=iOS Simulator,OS=latest,name=iPhone 5s'
+          xcode_destination: 'platform=iOS Simulator,OS=latest,name=iPhone 8'
         tvos:
           packager_platform: 'ios'
           xcode_sdk: appletvsimulator
@@ -27,6 +27,7 @@ jobs:
           xcode_scheme: 'RNTester-macOS'
           xcode_destination: 'platform=macOS,arch=x86_64'
     pool:
+      name: Hosted Mac Internal Mojave
       demands: ['xcode', 'sh', 'npm']
     timeoutInMinutes: 60 # how long to run the job before automatically cancelling
     cancelTimeoutInMinutes: 5 # how much time to give 'run always even if cancelled tasks' before killing them

.ado/templates/apple-xcode-build.yml

@@ -17,7 +17,7 @@ steps:
       sdk: ${{ parameters.xcode_sdk }}
       xcWorkspacePath: ${{ parameters.xcode_workspacePath }}
       scheme: ${{ parameters.xcode_scheme }}
-      xcodeVersion: 10
+      xcodeVersion: 11
       signingOption: auto
       packageApp: false
       teamId: '$(XCodeSigningMicrosoftTeamID)'

.ado/templates/apple-xcode-select.yml

@@ -2,32 +2,32 @@
 # Task Group: XCode select proper version
 #
 steps:
-  # The XCODE_10_DEVELOPER_DIR variable is defined in the Hosted Agents and is used by the Xcode@5 tasks.
+  # The XCODE_11_DEVELOPER_DIR variable is defined in the Hosted Agents and is used by the Xcode@5 tasks.
   # The 'OE Mac Pool' agents do not define this variable, so manually set it here if it is not defined.
   - script: |
-      if [ -z $XCODE_10_DEVELOPER_DIR ]; then 
-        DIR='/Applications/Xcode_10.1.app/Contents/Developer/'
+      if [ -z $XCODE_11_DEVELOPER_DIR ]; then 
+        DIR='/Applications/Xcode_11_beta.app/Contents/Developer/'
         if [ ! -d $DIR ]; then
           DIR='/Applications/Xcode.app/Contents/Developer/'
         fi
         if [ -d $DIR ]; then
-          echo "##vso[task.setvariable variable=XCODE_10_DEVELOPER_DIR;]$DIR"
+          echo "##vso[task.setvariable variable=XCODE_11_DEVELOPER_DIR;]$DIR"
         else
           (>&2 echo "No Xcode found.")
         fi
       fi
-    displayName: 'Ensure XCODE_10_DEVELOPER_DIR'
+    displayName: 'Ensure XCODE_11_DEVELOPER_DIR'
     failOnStderr: true
 
   # The DEVELOPER_DIR variable is used by xcodebuild to specify the version of Xcode to use.
   # Set the variable here so that npm components and CMake build steps get the latest XCode version
   # instead of whatever version is the default on the build agent.
   - script: |
-      echo "##vso[task.setvariable variable=DEVELOPER_DIR;]$XCODE_10_DEVELOPER_DIR"
+      echo "##vso[task.setvariable variable=DEVELOPER_DIR;]$XCODE_11_DEVELOPER_DIR"
     displayName: 'Set DEVELOPER_DIR'
 
   - script: |
-      REQUIRED=10.1
+      REQUIRED=11.0
       VER=`xcodebuild -version | head -n1 | cut -d' ' -f2`
       if (( $(echo "$VER >= $REQUIRED" | bc -l) )); then
         echo "XCode version $VER is active."

Brewfile

@@ -1,2 +1,2 @@
-brew "node@8", link: true
+brew "node@10", link: true
 brew "watchman"

RNTester/RNTester.xcodeproj/project.pbxproj

@@ -2059,6 +2059,9 @@
 					3D13F83D1D6F6AE000E69E0E = {
 						CreatedOnToolsVersion = 7.3.1;
 					};
+					641DD8E51F16AA8500B6415F = {
+						ProvisioningStyle = Automatic;
+					};
 				};
 			};
 			buildConfigurationList = 83CBB9FA1A601CBA00E9B192 /* Build configuration list for PBXProject "RNTester" */;
@@ -3830,12 +3833,16 @@
 			isa = XCBuildConfiguration;
 			buildSettings = {
 				CLANG_ANALYZER_NONNULL = YES;
+				CODE_SIGN_IDENTITY = "-";
+				CODE_SIGN_STYLE = Automatic;
 				COMBINE_HIDPI_IMAGES = YES;
+				DEVELOPMENT_TEAM = "";
 				GCC_NO_COMMON_BLOCKS = YES;
 				INFOPLIST_FILE = "RNTesterBundle copy-Info.plist";
 				MACOSX_DEPLOYMENT_TARGET = 10.10;
 				PRODUCT_BUNDLE_IDENTIFIER = com.facebook.RNTesterBundle;
 				PRODUCT_NAME = "$(TARGET_NAME)";
+				PROVISIONING_PROFILE_SPECIFIER = "";
 				SDKROOT = macosx;
 				WRAPPER_EXTENSION = bundle;
 			};
@@ -3845,12 +3852,16 @@
 			isa = XCBuildConfiguration;
 			buildSettings = {
 				CLANG_ANALYZER_NONNULL = YES;
+				CODE_SIGN_IDENTITY = "-";
+				CODE_SIGN_STYLE = Automatic;
 				COMBINE_HIDPI_IMAGES = YES;
+				DEVELOPMENT_TEAM = "";
 				GCC_NO_COMMON_BLOCKS = YES;
 				INFOPLIST_FILE = "RNTesterBundle copy-Info.plist";
 				MACOSX_DEPLOYMENT_TARGET = 10.10;
 				PRODUCT_BUNDLE_IDENTIFIER = com.facebook.RNTesterBundle;
 				PRODUCT_NAME = "$(TARGET_NAME)";
+				PROVISIONING_PROFILE_SPECIFIER = "";
 				SDKROOT = macosx;
 				WRAPPER_EXTENSION = bundle;
 			};

RNTester/RNTesterIntegrationTests/RNTesterSnapshotTests.m

@@ -39,16 +39,16 @@ - (void)test##name                      \
   [_runner runTest:_cmd module:@#name]; \
 }
 
-// TODO(ISS#2739352: the tests disabled below do not reliably pass on XCode 10.1)
-//RCT_TEST(ViewExample)
+RCT_TEST(ViewExample)
 RCT_TEST(LayoutExample)
 RCT_TEST(ARTExample)
 RCT_TEST(ScrollViewExample)
-//RCT_TEST(TextExample)
 #if !TARGET_OS_TV
+// TODO(OSS Candidate ISS#2710739): RCTPicker which TextExample depends on not available on tvOS
+RCT_TEST(TextExample)
 // No switch or slider available on tvOS
-//RCT_TEST(SwitchExample)
-//RCT_TEST(SliderExample)
+RCT_TEST(SwitchExample)
+RCT_TEST(SliderExample)
 #endif
 
 - (void)testZZZNotInRecordMode