Skip to content

Commit 95c52a3

Browse files
authored
fix: make roll runnable on Windows (#1614)
1 parent 2d0e03c commit 95c52a3

File tree

2 files changed

+3
-23
lines changed

2 files changed

+3
-23
lines changed

Diff for: README.md

-20
Original file line numberDiff line numberDiff line change
@@ -39,26 +39,6 @@ npm run serve
3939

4040
### Running this on Windows
4141

42-
If you don't already, you might need to set the default shell to `bash`.
43-
44-
```powershell
45-
npm config set script-shell "C:\\Program Files\\git\\bin\\bash.exe"
46-
```
47-
48-
You can revert it later, if you have issues, by doing:
49-
50-
```powershell
51-
npm config delete script-shell
52-
```
53-
54-
In some cases, the `postinstall` script doesn't auto-run after `npm install`, in which case, you can run that manually:
55-
56-
```sh
57-
npm run postinstall
58-
```
59-
60-
That should bring your environment to a state ready for testing.
61-
6242
To roll the docs in PowerShell, make sure you set the env variable correctly, i.e.:
6343

6444
```powershell

Diff for: package.json

+3-3
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
"swizzle": "docusaurus swizzle",
1212
"clear": "docusaurus clear",
1313
"sync-upstream-scripts": "node src/sync_upstream_scripts.js",
14-
"roll": "rm -rf nodejs/docs/* && rm -rf python/docs/* && rm -rf java/docs/* && rm -rf dotnet/docs/* && npm run sync-upstream-scripts && node src/generate.js",
14+
"roll": "rimraf -g nodejs/docs/* && rimraf -g python/docs/* && rimraf -g java/docs/* && rimraf -g dotnet/docs/* && npm run sync-upstream-scripts && node src/generate.js",
1515
"start-dotnet": "concurrently \"node src/generate.js --watch csharp\" \"npm run start\"",
1616
"start-java": "concurrently \"node src/generate.js --watch java\" \"npm run start\"",
1717
"start-nodejs": "concurrently \"node src/generate.js --watch js\" \"npm run start\"",
@@ -24,12 +24,12 @@
2424
"build-python": "npm run cleanup && cp -r python/* . && node --max-old-space-size=4096 node_modules/.bin/docusaurus build --out-dir=build/python",
2525
"build-java": "npm run cleanup && cp -r java/* . && node --max-old-space-size=4096 node_modules/.bin/docusaurus build --out-dir=build/java",
2626
"build-dotnet": "npm run cleanup && cp -r dotnet/* . && node --max-old-space-size=4096 node_modules/.bin/docusaurus build --out-dir=build/dotnet",
27-
"build": "tsc && rm -rf build && npm run build-nodejs && npm run build-python && npm run build-java && npm run build-dotnet",
27+
"build": "tsc && rimraf -g build && npm run build-nodejs && npm run build-python && npm run build-java && npm run build-dotnet",
2828
"version-dotnet": "npm run prepare-dotnet && docusaurus docs:version stable && cp -r docs/* dotnet/docs/ && cp -r versioned_docs/* dotnet/versioned_docs/ && cp -r versioned_sidebars/* dotnet/versioned_sidebars/ && cp versions.json dotnet/",
2929
"version-java": "npm run prepare-java && docusaurus docs:version stable && cp -r docs/* java/docs/ && cp -r versioned_docs/* java/versioned_docs/ && cp -r versioned_sidebars/* java/versioned_sidebars/ && cp versions.json java/",
3030
"version-node": "npm run prepare-nodejs && docusaurus docs:version stable && cp -r docs/* nodejs/docs/ && cp -r versioned_docs/* nodejs/versioned_docs/ && cp -r versioned_sidebars/* nodejs/versioned_sidebars/ && cp versions.json nodejs/",
3131
"version-python": "npm run prepare-python && docusaurus docs:version stable && cp -r docs/* python/docs/ && cp -r versioned_docs/* python/versioned_docs/ && cp -r versioned_sidebars/* python/versioned_sidebars/ && cp versions.json python/",
32-
"cleanup": "rm -rf docs versioned_docs versioned_sidebars docusaurus.config.ts versions.json sidebars.js",
32+
"cleanup": "rimraf -g docs versioned_docs versioned_sidebars docusaurus.config.ts versions.json sidebars.js",
3333
"version-all": "npm run version-python && npm run version-node && npm run version-java && npm run version-dotnet",
3434
"serve": "docusaurus serve"
3535
},

0 commit comments

Comments
 (0)