3333 List ,
3434 Optional ,
3535)
36- from urllib .parse import urlparse
3736
3837import pytest
3938
@@ -77,6 +76,7 @@ async def connect_browser(
7776) -> Browser :
7877 """Port of the connect fixture: passes the launch options for run-server along."""
7978 with redirect_port_forwarding_for_test (browser_type , redirect_port_for_test ):
79+ # Python: launchOptions is JavaScript-only; send its header directly.
8080 return await browser_type .connect (
8181 ws_endpoint ,
8282 headers = {
@@ -305,7 +305,7 @@ def handle_ws(ws: WebSocketProtocol) -> None:
305305 server .once_web_socket_connection (handle_ws )
306306 with pytest .raises (Error ) as exc_info :
307307 await connect (f"ws://localhost:{ server .PORT } /ws" )
308- assert "BrowserType.connect: Oh my!" in exc_info .value .message
308+ assert "Oh my!" in exc_info .value .message
309309
310310
311311@pytest .mark .parametrize ("kind" , KINDS )
@@ -471,7 +471,7 @@ def upgrade() -> None:
471471 server .set_route ("/ws-slow" , handle_ws_slow )
472472 with pytest .raises (Error ) as exc_info :
473473 await connect (f"ws://localhost:{ server .PORT } /ws-slow" , timeout = 1000 )
474- assert "BrowserType.connect: Timeout 1000ms exceeded" in exc_info .value .message
474+ assert "Timeout 1000ms exceeded" in exc_info .value .message
475475
476476
477477@pytest .mark .parametrize ("kind" , KINDS )
@@ -484,7 +484,7 @@ async def test_BT_045_should_timeout_in_connect_while_connecting(
484484 server .once_web_socket_connection (server_web_sockets .append )
485485 with pytest .raises (Error ) as exc_info :
486486 await connect (f"ws://localhost:{ server .PORT } /ws" , timeout = 100 )
487- assert "BrowserType.connect: Timeout 100ms exceeded" in exc_info .value .message
487+ assert "Timeout 100ms exceeded" in exc_info .value .message
488488
489489
490490@pytest .mark .parametrize ("kind" , KINDS )
@@ -1138,6 +1138,7 @@ async def test_BT_071_should_be_able_to_connect_when_the_ws_endpoint_is_passed_a
11381138 start_remote_server : RemoteServerStarter ,
11391139) -> None :
11401140 remote_server = start_remote_server (kind )
1141+ # Python: launchOptions is JavaScript-only; send its header directly.
11411142 browser = await browser_type .connect (
11421143 endpoint = remote_server .ws_endpoint ,
11431144 headers = {
@@ -1376,20 +1377,6 @@ async def test_BT_078_set_input_files_should_preserve_last_modified_timestamp(
13761377 ), f"expected: { expected_timestamps } ; actual: { timestamps } "
13771378
13781379
1379- @pytest .mark .parametrize ("kind" , KINDS )
1380- async def test_BT_079_should_connect_over_http (
1381- kind : str ,
1382- connect : Callable [..., Awaitable [Browser ]],
1383- start_remote_server : RemoteServerStarter ,
1384- ) -> None :
1385- remote_server = start_remote_server (kind )
1386-
1387- url = urlparse (remote_server .ws_endpoint )
1388- browser = await connect (f"http://localhost:{ url .port } " )
1389- assert browser .version
1390- await browser .close ()
1391-
1392-
13931380def skip_socks_proxy (kind : str ) -> None :
13941381 """Port of the test.skip() of the 'socks proxy' describe."""
13951382 if kind == KIND_LAUNCH_SERVER :
@@ -1872,23 +1859,3 @@ async def test_BT_094_should_filter_local_paths_from_unsafe_launch_options(
18721859
18731860 actions = trace_actions (read_trace (trace_path ))
18741861 assert "Frame.setContent" in actions
1875-
1876-
1877- async def test_BT_095_should_timeout_after_redirect_when_connecting_over_http (
1878- playwright : Playwright ,
1879- connect : Callable [..., Awaitable [Browser ]],
1880- server : Server ,
1881- ) -> None :
1882- server .set_redirect ("/connect/json" , "/connect/slow" )
1883- aborted : List [bool ] = []
1884-
1885- def handle_slow (request : TestServerRequest ) -> None :
1886- request .notifyFinish ().addErrback (lambda _ : aborted .append (True ))
1887-
1888- server .set_route ("/connect/slow" , handle_slow )
1889- with pytest .raises (Error ) as exc_info :
1890- await connect (
1891- f"{ server .PREFIX } /connect" , timeout = 2000 , headers = {"Connection" : "Close" }
1892- )
1893- assert "Timeout 2000ms exceeded." in exc_info .value .message
1894- await poll (playwright , lambda : aborted == [True ])
0 commit comments