Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify gen_docker_image.sh #213

Open
shiranr opened this issue Oct 17, 2024 · 1 comment
Open

Simplify gen_docker_image.sh #213

shiranr opened this issue Oct 17, 2024 · 1 comment

Comments

@shiranr
Copy link

shiranr commented Oct 17, 2024

Can the gen_docker_image.sh be simplified by having it as a script in the action:

    CONFIG_PATH="./$USE_CASE_BASE_PATH/experiment.yaml"
    REGISTRY_ENDPOINT="$DOCKER_IMAGE_REGISTRY.azurecr.io"
    FLOW_NAME=$(yq '.flow' "$CONFIG_PATH" |  sed 's/"//g')
    IMAGE_NAME="$REGISTRY_ENDPOINT"/"$USE_CASE_BASE_PATH"/"$FLOW_NAME"_"$DEPLOY_ENVIRONMENT"

    cd docker
    docker compose build --build-arg USE_CASE_BASE_PATH="$USE_CASE_BASE_PATH" --build-arg FLOW_NAME="$FLOW_NAME" promptflow

    docker tag docker-promptflow "$IMAGE_NAME":"$BUILD_ID"
    docker tag docker-promptflow "$IMAGE_NAME":"latest"

    docker push "$IMAGE_NAME":"$BUILD_ID"
    docker push "$IMAGE_NAME":"latest"
@ritesh-modi
Copy link
Collaborator

This was because we wanted to generate Docker Image even locally as an optional feature. We can evaluate this issue later if we really need it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants