Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependent changes are always prepatch when type is premajor #1027

Open
rdebeasi opened this issue Dec 13, 2024 · 0 comments
Open

Dependent changes are always prepatch when type is premajor #1027

rdebeasi opened this issue Dec 13, 2024 · 0 comments

Comments

@rdebeasi
Copy link

rdebeasi commented Dec 13, 2024

When I use the type premajor, dependent changes are always prepatch, even when I specify something else in dependentChangeType. Is this intentional? Or, do I need to specify premajor instead of major for dependents?

I realize that prerelease changes are somewhat hidden (#947), so I might be stumbling onto functionality that hasn't been fully defined. 🙂

Thank you for your time!

Example

// beachball.config.js
module.exports = {
  prereleasePrefix: 'rc',
};
// a change file
{
  "comment": "feat: Inputs are purple now!!",
  "type": "premajor",
  "packageName": "@myorg/myinput",
  "email": "[email protected]",
  "dependentChangeType": "major"
}
// package.json for @myorg/myinput
"name": "@myorg/myinput",
"version": "1.1.0",
// package.json for a package that depends on @myorg/myinput
"name": "@myorg/mydependent",
"version": "1.19.0",

Expected behavior

When I run beachball bump, I expect to see the following updates:

  • @myorg/myinput 2.0.0-rc.0
  • @myorg/mydependent 2.0.0

Alternative: Beachball could throw an error saying something like, "Only prerelease changes are available when the repo is in prerelease mode. Please select premajor, preminor, or prepatch."

Actual behavior

When I run beachball bump, I actually see the following updates:

  • @myorg/myinput 2.0.0-rc.0
  • @myorg/mydependent 1.19.1-rc.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant