Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update doc to make it obvious that on_messages is meant for delta. #4817

Closed
ekzhu opened this issue Dec 26, 2024 · 0 comments · Fixed by #4819
Closed

Update doc to make it obvious that on_messages is meant for delta. #4817

ekzhu opened this issue Dec 26, 2024 · 0 comments · Fixed by #4819
Assignees
@ekzhu
Labels
documentation Improvements or additions to documentation proj-agentchat
Milestone
0.4.0

Comments

@ekzhu
Copy link
Collaborator

ekzhu commented Dec 26, 2024

I thought initially that messages would always be the complete messages, which is not the case. Sorry my bad!

We should update the docs so it becomes obvious that the on_messages is meant for delta not complete history.

Originally posted by @ekzhu in #4810
@ekzhu ekzhu self-assigned this Dec 26, 2024
@ekzhu ekzhu added the documentation Improvements or additions to documentation label Dec 26, 2024
@ekzhu ekzhu added this to the 0.4.0 milestone Dec 26, 2024
@ekzhu ekzhu mentioned this issue Dec 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ekzhu ekzhu

Labels
documentation Improvements or additions to documentation proj-agentchat
Projects
None yet
Milestone
0.4.0
Development

Successfully merging a pull request may close this issue.

Emphasis on_messages is for new messages only; remove unused file. microsoft/autogen
1 participant
@ekzhu