Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Documentation have a flattened list of all the modules and classes #4377

Closed
ekzhu opened this issue Nov 26, 2024 · 5 comments · Fixed by #4556
Closed

API Documentation have a flattened list of all the modules and classes #4377

ekzhu opened this issue Nov 26, 2024 · 5 comments · Fixed by #4556
Assignees
Labels
documentation Improvements or additions to documentation proj-agentchat proj-core proj-extensions
Milestone

Comments

@ekzhu
Copy link
Collaborator

ekzhu commented Nov 26, 2024

Just a flattened list of all the modules and classes that is ordered by full module name.

@gagb
Copy link
Collaborator

gagb commented Nov 30, 2024

I tried to do this. One solution is to set the left padding of the ul element in the side navbar, but the challenges is that changes the global settings.

A better solution is to add a class to the API reference page, and selectively apply this CSS modifier. But I for love of god can't figure out how to do that.

The toctree lives outside the main page content, so adding :class: to toctree definition in reference/index.md does not work. Similarly wrapping the contents of the same index.md in a <div class="reference"></div> does not work.

I worry that the best solution maybe to create a custom toctree, somehow. But I am not at all sure how to do that. cc @jackgerrits

It's really worth doing it tho, this is what our page would look like. It's much much more readable. cc @afourney

Image

@afourney
Copy link
Member

Agree. Principle at hand is recognition over recall.

@ekzhu
Copy link
Collaborator Author

ekzhu commented Dec 5, 2024

Ah not done yet. The page with a flattened list of all classes is still not there.

@jackgerrits
Copy link
Member

jackgerrits commented Dec 27, 2024

Not sure if we can do this within the same site or not. Essentially it would break all of the anchors and class references etc, as now there would be two locations of the docs.

We could generate a new site and host it under a new directory but thats a bit confusing.

There's a builder which outputs the whole website as one big html file. It's pretty cool to see, but again not sure where we would host it in a way that makes sense for navigation.

Attaching it here for curiosity though: build-single-html.zip

Overall I'm not sure how to pull this off in a way that doesn't break things or duplicate things in a confusing way.

@ekzhu
Copy link
Collaborator Author

ekzhu commented Dec 27, 2024

Moving this to the next release.

@ekzhu ekzhu modified the milestones: 0.4.0, 0.4.1 Dec 27, 2024
@jackgerrits jackgerrits modified the milestones: 0.4.1, 0.4.x Jan 13, 2025
@ekzhu ekzhu closed this as completed Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation proj-agentchat proj-core proj-extensions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants