Move iterables into main d.ts files in 6.0, reference es2015 and es2018.asynciterable #2168
+82,018
−1,631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
Sorry @saschanaz, you don't have access to these files: |
|
Can I add |
|
That has nothing to do with this PR |
|
But it is effectively blocked by this, so maybe? |
|
Hm, maybe? It wouldn't work for older TS versions, so I'm not sure where we'd put it other than to not generate it at all for older TS? |
|
I mean we already make things different for different TS versions. But anyway this discussion can continue in #1762 after this PR. |
|
Yeah, sorry, I did not realize that they were referring to the side effect change of the types referencing es2015 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For microsoft/TypeScript#62111