Skip to content
This repository was archived by the owner on Jan 12, 2024. It is now read-only.

Commit 59438bf

Browse files
msoekentcNickolas
andauthored
API review July 2022 (#608)
* API review July 2022 * Apply suggestions from code review Co-authored-by: Mariia Mykhailova <[email protected]> * Apply suggestions from code review * Apply suggestions from code review * Update api-design-2022-07.md * Update api-design-2022-07.md Co-authored-by: Mariia Mykhailova <[email protected]>
1 parent 3f66179 commit 59438bf

File tree

1 file changed

+60
-0
lines changed

1 file changed

+60
-0
lines changed
+60
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,60 @@
1+
# Q# API Design Discussions / July 2022
2+
3+
Reviewers (in order by username): @tcNickolas, @msoeken, @cgranade
4+
5+
## Agenda
6+
7+
- https://github.com/microsoft/QuantumLibraries/issues/598
8+
- https://github.com/microsoft/QuantumLibraries/issues/601
9+
- https://github.com/microsoft/QuantumLibraries/issues/602
10+
- https://github.com/microsoft/QuantumLibraries/issues/607
11+
12+
## Discussion
13+
14+
### Fixed point truncation
15+
16+
**Proposal**: https://github.com/microsoft/QuantumLibraries/issues/598
17+
18+
**Reviews**:
19+
* @tcNickolas, *approve*, left a comment
20+
> Please add a bullet point including your alias, your review result (*approve*, *reject*, *comment*), and a comment (optional when result is *approve*). Alternatively, add a line to the PR discussion incl. a reference to this issue.
21+
22+
**Consensus**: Approved
23+
24+
---
25+
26+
### Table lookup
27+
28+
**Proposal**: https://github.com/microsoft/QuantumLibraries/issues/601
29+
30+
**Reviews**:
31+
* @tcNickolas, *approve*, left comments
32+
* @msoeken, *approve*, left comments
33+
> Please add a bullet point including your alias, your review result (*approve*, *reject*, *comment*), and a comment (optional when result is *approve*). Alternatively, add a line to the PR discussion incl. a reference to this issue.
34+
35+
**Consensus**: Postponed, requires more discussion
36+
37+
---
38+
39+
### Windowed unitary application
40+
41+
**Proposal**: https://github.com/microsoft/QuantumLibraries/issues/602
42+
43+
**Reviews**:
44+
* @tcNickolas, *approve*
45+
* @msoeken, *approve*, left comments
46+
> Please add a bullet point including your alias, your review result (*approve*, *reject*, *comment*), and a comment (optional when result is *approve*). Alternatively, add a line to the PR discussion incl. a reference to this issue.
47+
48+
**Consensus**: Approved as `ApplyToEachWindow` without `argumentTransform`, without `target` argument, with type parameter for input array, and with all 4 functor variants.
49+
50+
---
51+
52+
### New operation: Apply arithmetic function via table lookup
53+
54+
**Proposal**: https://github.com/microsoft/QuantumLibraries/issues/607
55+
56+
**Reviews**:
57+
> Please add a bullet point including your alias, your review result (*approve*, *reject*, *comment*), and a comment (optional when result is *approve*). Alternatively, add a line to the PR discussion incl. a reference to this issue.
58+
* @msoeken, *approve*, left comments
59+
60+
**Consensus**: Approved after comments

0 commit comments

Comments
 (0)