build: Update eslint-config-fluid and other eslint dependencies (#25525)

Updates all packages except those in client. Those will be tackled in a
separate PR.

While the update to our config did not contain explicit rule changes,
upstream configs' rules were updated in ways that affect us. As a
result, some code changes were required.

---------

Co-authored-by: Alex Villarreal <[email protected]>

Author: Josmithr

.github/workflows/website-validation.yml

@@ -32,7 +32,7 @@ jobs:
       - uses: pnpm/action-setup@fe02b34f77f8bc703788d5817da081398fad5dd2 # ratchet:pnpm/action-setup@v4
       - uses: actions/setup-node@1a4442cacd436585916779262731d5b162bc6ec7 # ratchet:actions/setup-node@v3
         with:
-          node-version: "18"
+          node-version: "20"
           cache: "pnpm"
           cache-dependency-path: docs/pnpm-lock.yaml
       - name: Build site artifact
@@ -61,7 +61,7 @@ jobs:
       - uses: pnpm/action-setup@fe02b34f77f8bc703788d5817da081398fad5dd2 # ratchet:pnpm/action-setup@v4
       - uses: actions/setup-node@1a4442cacd436585916779262731d5b162bc6ec7 # ratchet:actions/setup-node@v3
         with:
-          node-version: "18"
+          node-version: "20"
           cache: "pnpm"
           cache-dependency-path: docs/pnpm-lock.yaml
       - name: pnpm lint
@@ -81,7 +81,7 @@ jobs:
       - uses: pnpm/action-setup@fe02b34f77f8bc703788d5817da081398fad5dd2 # ratchet:pnpm/action-setup@v4
       - uses: actions/setup-node@1a4442cacd436585916779262731d5b162bc6ec7 # ratchet:actions/setup-node@v3
         with:
-          node-version: "18"
+          node-version: "20"
           cache: "pnpm"
           cache-dependency-path: docs/pnpm-lock.yaml
 
@@ -109,7 +109,7 @@ jobs:
       - uses: pnpm/action-setup@fe02b34f77f8bc703788d5817da081398fad5dd2 # ratchet:pnpm/action-setup@v4
       - uses: actions/setup-node@1a4442cacd436585916779262731d5b162bc6ec7 # ratchet:actions/setup-node@v3
         with:
-          node-version: "18"
+          node-version: "20"
           cache: "pnpm"
           cache-dependency-path: docs/pnpm-lock.yaml
       - name: Create results folder

build-tools/packages/build-cli/package.json

@@ -144,7 +144,7 @@
 	"devDependencies": {
 		"@biomejs/biome": "~1.9.3",
 		"@fluidframework/build-common": "^2.0.3",
-		"@fluidframework/eslint-config-fluid": "^6.0.0",
+		"@fluidframework/eslint-config-fluid": "^6.1.0",
 		"@oclif/test": "^4.1.0",
 		"@types/async": "^3.2.24",
 		"@types/chai": "^5.2.1",

build-tools/packages/build-cli/src/library/layerGraph.ts

@@ -254,7 +254,7 @@ class PackageNode extends BaseNode {
 	/**
 	 * Packages this package is directly dependent upon
 	 */
-	public get childDependencies(): Readonly<PackageNode[]> {
+	public get childDependencies(): readonly PackageNode[] {
 		return this._childDependencies;
 	}
 

build-tools/packages/build-cli/src/library/repoPolicyCheck/npmPackages.ts

@@ -1418,6 +1418,7 @@ export const handlers: Handler[] = [
 			const mochaScriptName = scripts["test:mocha"] === undefined ? "test" : "test:mocha";
 			const mochaScript = scripts[mochaScriptName];
 
+			// eslint-disable-next-line @typescript-eslint/prefer-optional-chain -- Existing logic is easier to read
 			if (mochaScript === undefined || !mochaScript.startsWith("mocha")) {
 				// skip irregular test script for now
 				return undefined;
@@ -1455,6 +1456,7 @@ export const handlers: Handler[] = [
 			const jestScriptName = scripts["test:jest"] === undefined ? "test" : "test:jest";
 			const jestScript = scripts[jestScriptName];
 
+			// eslint-disable-next-line @typescript-eslint/prefer-optional-chain -- Existing logic is easier to read
 			if (jestScript === undefined || !jestScript.startsWith("jest")) {
 				// skip irregular test script for now
 				return undefined;

build-tools/packages/build-infrastructure/package.json

@@ -83,7 +83,7 @@
 		"@fluid-tools/api-markdown-documenter": "^0.17.1",
 		"@fluidframework/build-common": "^2.0.3",
 		"@fluidframework/build-tools-bin": "npm:@fluidframework/build-tools@~0.49.0",
-		"@fluidframework/eslint-config-fluid": "^6.0.0",
+		"@fluidframework/eslint-config-fluid": "^6.1.0",
 		"@microsoft/api-extractor": "^7.52.11",
 		"@types/chai": "^5.2.1",
 		"@types/chai-arrays": "^2.0.3",

build-tools/packages/build-tools/package.json

@@ -69,7 +69,7 @@
 		"@biomejs/biome": "~1.9.3",
 		"@fluidframework/build-common": "^2.0.3",
 		"@fluidframework/build-tools-bin": "npm:@fluidframework/build-tools@~0.49.0",
-		"@fluidframework/eslint-config-fluid": "^6.0.0",
+		"@fluidframework/eslint-config-fluid": "^6.1.0",
 		"@types/async": "^3.2.24",
 		"@types/fs-extra": "^11.0.4",
 		"@types/glob": "^7.2.0",

build-tools/packages/bundle-size-tools/package.json

@@ -51,7 +51,7 @@
 		"@biomejs/biome": "~1.9.3",
 		"@fluidframework/build-common": "^2.0.3",
 		"@fluidframework/build-tools-bin": "npm:@fluidframework/build-tools@~0.49.0",
-		"@fluidframework/eslint-config-fluid": "^6.0.0",
+		"@fluidframework/eslint-config-fluid": "^6.1.0",
 		"@microsoft/api-extractor": "^7.52.11",
 		"@types/msgpack-lite": "^0.1.11",
 		"@types/node": "^18.19.59",

build-tools/packages/version-tools/package.json

@@ -89,7 +89,7 @@
 		"@biomejs/biome": "~1.9.3",
 		"@fluidframework/build-common": "^2.0.3",
 		"@fluidframework/build-tools-bin": "npm:@fluidframework/build-tools@~0.49.0",
-		"@fluidframework/eslint-config-fluid": "^6.0.0",
+		"@fluidframework/eslint-config-fluid": "^6.1.0",
 		"@microsoft/api-extractor": "^7.52.11",
 		"@oclif/test": "^4.1.0",
 		"@types/chai": "^5.2.1",