The children issues are sourced from the spec, however there are likely more validation rules that should be added.
The children issues of this one specifically focus on DXIL validation. Because of this rules should be implemented in lib/DxilValidation/DxilValidation.cpp with tests written in tools/clang/test/LitDXILValidation/LinAlgMatrix/. #8588 is a (larger) example of what this looks like
For all the children issues covering a builtin there are common validation that should be ran such as
- Are the dims acceptable for the operation
- Is the matrix use, scope, and component acceptable for the operation
It's not needed to check if the operation is allowed in the shader type as that verified elsewhere
The children issues are sourced from the spec, however there are likely more validation rules that should be added.
The children issues of this one specifically focus on DXIL validation. Because of this rules should be implemented in
lib/DxilValidation/DxilValidation.cppwith tests written intools/clang/test/LitDXILValidation/LinAlgMatrix/. #8588 is a (larger) example of what this looks likeFor all the children issues covering a builtin there are common validation that should be ran such as
It's not needed to check if the operation is allowed in the shader type as that verified elsewhere