Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Airlock notifier doesn't notify of rejected requests #4094

Open
TonyWildish-BH opened this issue Sep 20, 2024 · 2 comments
Open

Airlock notifier doesn't notify of rejected requests #4094

TonyWildish-BH opened this issue Sep 20, 2024 · 2 comments
Labels
story Stories are the smallest unit of work to be done for a project.

Comments

@TonyWildish-BH
Copy link
Contributor

Describe the bug
The Airlock Notifier workflow notifies the workspace team that a request has been approved, but it doesn't notify them that a request has been rejected. So if the Airlock Manager rejects a request, they are left without any indication of that unless they happen to be polling the status page.

This is undesirable, the user should be notified of the rejection, and the reviewer's reason for rejecting the request should be included.

Steps to reproduce

  1. As a Workspace team member, create an airlock import or export request
  2. As an Airlock Manager, reject the request
  3. Wait for an email that never comes

Azure TRE release version (e.g. v0.14.0 or main):

Deployed Azure TRE components - click the (i) in the UI:

@TonyWildish-BH TonyWildish-BH added the bug Something isn't working label Sep 20, 2024
@TonyWildish-BH
Copy link
Contributor Author

P.S. Airlock notifier template version 0.9.0.

@Danny-Cooke-CK
Copy link
Collaborator

Hi Tony. Interesting observation. Seems reasonable that we should expect a notification for all status changes.

@tim-p-allen tim-p-allen added story Stories are the smallest unit of work to be done for a project. and removed bug Something isn't working labels Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
story Stories are the smallest unit of work to be done for a project.
Projects
Status: No status
Development

No branches or pull requests

3 participants