Remove unnecessary hasattr check in exception handler

Copilot · pontemonti · Copilot · commit fe26a987c0e2 · 2025-12-30T17:24:48.000Z
Co-authored-by: pontemonti &lt;7850950+pontemonti@users.noreply.github.com&gt;
diff --git a/libraries/microsoft-agents-a365-tooling-extensions-agentframework/microsoft_agents_a365/tooling/extensions/agentframework/services/mcp_tool_registration_service.py b/libraries/microsoft-agents-a365-tooling-extensions-agentframework/microsoft_agents_a365/tooling/extensions/agentframework/services/mcp_tool_registration_service.py
@@ -133,9 +133,8 @@ async def add_tool_servers_to_agent(
                     self._logger.info(f"Added MCP plugin '{server_name}' to agent tools")
 
                 except Exception as tool_ex:
-                    server_name = config.mcp_server_name if hasattr(config, "mcp_server_name") else "Unknown"
                     self._logger.warning(
-                        f"Failed to create MCP plugin for {server_name}: {tool_ex}"
+                        f"Failed to create MCP plugin for {config.mcp_server_name}: {tool_ex}"
                     )
                     continue
 

Original file line number	Diff line number	Diff line change
`@@ -133,9 +133,8 @@ async def add_tool_servers_to_agent(`
`133`	`133`	`self._logger.info(f"Added MCP plugin '{server_name}' to agent tools")`
`134`	`134`
`135`	`135`	`except Exception as tool_ex:`
`136`		`- server_name = config.mcp_server_name if hasattr(config, "mcp_server_name") else "Unknown"`
`137`	`136`	`self._logger.warning(`
`138`		`- f"Failed to create MCP plugin for {server_name}: {tool_ex}"`
	`137`	`+ f"Failed to create MCP plugin for {config.mcp_server_name}: {tool_ex}"`
`139`	`138`	`)`
`140`	`139`	`continue`
`141`	`140`