Skip to content

Commit addb816

Browse files
CopilotnikhilNava
andauthored
Remove redundant null check in conversation ID extraction (#64)
* Initial plan * Remove redundant condition in _iter_conversation_pairs Co-authored-by: nikhilNava <211831449+nikhilNava@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: nikhilNava <211831449+nikhilNava@users.noreply.github.com>
1 parent d742519 commit addb816

1 file changed

Lines changed: 2 additions & 5 deletions

File tree

  • libraries/microsoft-agents-a365-observability-core/microsoft_agents_a365/observability/core/middleware

libraries/microsoft-agents-a365-observability-core/microsoft_agents_a365/observability/core/middleware/turn_context_baggage.py

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -163,11 +163,8 @@ def _iter_source_metadata_pairs(activity: Any) -> Iterator[tuple[str, Any]]:
163163

164164

165165
def _iter_conversation_pairs(activity: Any) -> Iterator[tuple[str, Any]]:
166-
conversation_id = None
167-
168-
if not conversation_id:
169-
conv = _safe_get(activity, "conversation")
170-
conversation_id = _safe_get(conv, "id")
166+
conv = _safe_get(activity, "conversation")
167+
conversation_id = _safe_get(conv, "id")
171168

172169
item_link = _safe_get(activity, "service_url")
173170

0 commit comments

Comments
 (0)