Skip to content

Commit 8f7db20

Browse files
address pr comments
1 parent edc808f commit 8f7db20

2 files changed

Lines changed: 2 additions & 5 deletions

File tree

  • libraries
    • microsoft-agents-a365-observability-core/microsoft_agents_a365/observability/core
    • microsoft-agents-a365-observability-extensions-semantickernel/microsoft_agents_a365/observability/extensions/semantickernel

libraries/microsoft-agents-a365-observability-core/microsoft_agents_a365/observability/core/invoke_agent_scope.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,8 @@ def __init__(
127127
if request.channel:
128128
self.set_tag_maybe(CHANNEL_NAME_KEY, request.channel.name)
129129
self.set_tag_maybe(CHANNEL_LINK_KEY, request.channel.link)
130-
self.set_tag_maybe(GEN_AI_INPUT_MESSAGES_KEY, safe_json_dumps([request.content]))
130+
if request.content:
131+
self.set_tag_maybe(GEN_AI_INPUT_MESSAGES_KEY, safe_json_dumps([request.content]))
131132

132133
# Set caller details tags
133134
if caller_details:

libraries/microsoft-agents-a365-observability-extensions-semantickernel/microsoft_agents_a365/observability/extensions/semantickernel/span_processor.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33

44
from microsoft_agents_a365.observability.core.constants import (
55
GEN_AI_OPERATION_NAME_KEY,
6-
INVOKE_AGENT_OPERATION_NAME,
76
)
87
from microsoft_agents_a365.observability.core.inference_operation_type import InferenceOperationType
98
from microsoft_agents_a365.observability.core.utils import extract_model_name
@@ -39,9 +38,6 @@ def on_start(self, span: Span, parent_context: context_api.Context | None) -> No
3938
model_name = extract_model_name(span.name)
4039
span.update_name(f"{InferenceOperationType.CHAT.value.lower()} {model_name}")
4140

42-
if span.name.startswith(INVOKE_AGENT_OPERATION_NAME):
43-
pass
44-
4541
def on_end(self, span: ReadableSpan) -> None:
4642
"""
4743
Called when a span ends.

0 commit comments

Comments
 (0)