Skip to content

Commit 4a2bd66

Browse files
Copilotpontemonti
andcommitted
Move server_name assignment outside try block to ensure it's always available in exception handler
Co-authored-by: pontemonti <7850950+pontemonti@users.noreply.github.com>
1 parent cce7219 commit 4a2bd66

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

  • libraries/microsoft-agents-a365-tooling-extensions-agentframework/microsoft_agents_a365/tooling/extensions/agentframework/services

libraries/microsoft-agents-a365-tooling-extensions-agentframework/microsoft_agents_a365/tooling/extensions/agentframework/services/mcp_tool_registration_service.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -96,6 +96,9 @@ async def add_tool_servers_to_agent(
9696

9797
# Add servers as MCPStreamableHTTPTool instances
9898
for config in server_configs:
99+
# Use mcp_server_name if available, otherwise fall back to mcp_server_unique_name
100+
server_name = config.mcp_server_name or config.mcp_server_unique_name
101+
99102
try:
100103
# Prepare auth headers
101104
headers = {}
@@ -108,9 +111,6 @@ async def add_tool_servers_to_agent(
108111
self._orchestrator_name
109112
)
110113

111-
# Use mcp_server_name if available, otherwise fall back to mcp_server_unique_name
112-
server_name = config.mcp_server_name or config.mcp_server_unique_name
113-
114114
# Create and configure MCPStreamableHTTPTool
115115
mcp_tools = MCPStreamableHTTPTool(
116116
name=server_name,
@@ -129,7 +129,7 @@ async def add_tool_servers_to_agent(
129129

130130
except Exception as tool_ex:
131131
self._logger.warning(
132-
f"Failed to create MCP plugin for {config.mcp_server_name}: {tool_ex}"
132+
f"Failed to create MCP plugin for {server_name}: {tool_ex}"
133133
)
134134
continue
135135

0 commit comments

Comments
 (0)