Update commit skill to match CI check order

Reorders quality checks to run linting before formatting, matching
the CI pipeline order in .github/workflows/ci.yml. Adds a re-verify
step after auto-fixes to prevent commits that pass locally but fail
CI when lint fixes introduce formatting issues.

Co-Authored-By: Claude <noreply@anthropic.com>

Author: Johan Broberg

.claude/skills/commit/SKILL.md

@@ -1,6 +1,6 @@
 ---
 name: commit
-description: Use this skill when the user wants to commit staged changes. This skill checks formatting, runs linting, executes tests, generates a commit message, and commits the changes. Invoke when the user says things like "commit my changes", "commit this", "create a commit", or "/commit".
+description: Use this skill when the user wants to commit staged changes. This skill checks linting, then formatting (matching CI order), runs tests, generates a commit message, and commits the changes. Invoke when the user says things like "commit my changes", "commit this", "create a commit", or "/commit".
 allowed-tools: Bash, Read, Grep, Glob, Edit
 ---
 
@@ -18,9 +18,33 @@ git diff --cached --stat
 
 If there are no staged changes, inform the user and stop. Suggest they stage changes with `git add`.
 
-## Step 2: Check Code Formatting
+## Step 2: Check Linting
 
-Run the formatting check on the repository:
+Run the linting check first (matches CI order in .github/workflows/ci.yml):
+
+```bash
+uv run --frozen ruff check .
+```
+
+### If linting check fails:
+
+1. Inform the user about the linting errors
+2. Ask if they want you to auto-fix what can be auto-fixed
+3. If yes, run: `uv run --frozen ruff check . --fix`
+4. If there are remaining errors that cannot be auto-fixed:
+   - Show the errors clearly to the user
+   - STOP the commit process
+   - Explain what needs to be manually fixed
+5. If all errors were auto-fixed:
+   - Stage the fixes by running `git add` only on the files that were fixed
+   - Continue to the next step
+
+### If linting check passes:
+Continue to the next step.
+
+## Step 3: Check Code Formatting
+
+Run the formatting check (after linting, matches CI order):
 
 ```bash
 uv run --frozen ruff format --check .
@@ -32,37 +56,26 @@ uv run --frozen ruff format --check .
 2. Ask if they want you to auto-fix the formatting issues
 3. If yes, run: `uv run --frozen ruff format .`
 4. Show the user what files were reformatted
-5. Stage the formatting fixes by running `git add` only on the files that were reformatted (do not use `git add -u`)
+5. Stage the formatting fixes by running `git add` only on the files that were reformatted
 6. Continue to the next step
 
 ### If formatting check passes:
 Continue to the next step.
 
-## Step 3: Check Linting
+## Step 4: Re-verify After Auto-fixes
 
-Run the linting check:
+**IMPORTANT**: If any auto-fixes were applied in Steps 2 or 3, re-run both checks to ensure consistency:
 
 ```bash
 uv run --frozen ruff check .
+uv run --frozen ruff format --check .
 ```
 
-### If linting check fails:
+This prevents commits that pass locally but fail CI (e.g., lint fixes that introduce formatting issues). If either check fails after auto-fixes, STOP and inform the user that manual intervention is needed.
 
-1. Inform the user about the linting errors
-2. Ask if they want you to auto-fix what can be auto-fixed
-3. If yes, run: `uv run --frozen ruff check . --fix`
-4. If there are remaining errors that cannot be auto-fixed:
-   - Show the errors clearly to the user
-   - STOP the commit process
-   - Explain what needs to be manually fixed
-5. If all errors were auto-fixed:
-   - Stage the fixes: `git add -u`
-   - Continue to the next step
-
-### If linting check passes:
-Continue to the next step.
+If no auto-fixes were applied, skip this step.
 
-## Step 4: Run Tests
+## Step 5: Run Tests
 
 Run the unit tests (excluding integration tests):
 
@@ -84,7 +97,7 @@ uv run --frozen pytest tests/ -v --tb=short -m "not integration" 2>&1
 ### If tests pass:
 Continue to the next step.
 
-## Step 5: Generate Commit Message
+## Step 6: Generate Commit Message
 
 Analyze the staged changes to generate an appropriate commit message:
 
@@ -113,7 +126,7 @@ Types of changes to identify:
 - `Test` - Adding or updating tests
 - `Chore` - Maintenance tasks
 
-## Step 6: Confirm and Commit
+## Step 7: Confirm and Commit
 
 1. Show the user the proposed commit message
 2. Ask if they want to proceed with this message or modify it