refactor: address code review issues in publish command cleanup

- Remove unused agentBlueprintService parameter from CreateCommand signature
  and its callsite in Program.cs (CR-001)
- Replace magic-number zip cap (4) and arbitrary file padding loop with a
  clean LINQ expression over known candidate filenames (CR-002)
- Remove dead --verbose option binding in publish command handler; startup-
  level --verbose in Program.cs continues to work (CR-003)
- Add CHANGELOG [Unreleased] entry for the breaking behavior change (CR-004)
- Remove redundant Console.SetIn call inside zip creation test; constructor
  already sets it (CR-005)

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: sellakumaran

CHANGELOG.md

@@ -6,6 +6,9 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/).
 
 ## [Unreleased]
 
+### Changed
+- `a365 publish` no longer uploads the agent automatically. It now updates manifest IDs, creates `manifest.zip`, and prints instructions for manually uploading via Microsoft 365 Admin Center (Agents > All agents > Upload custom agent).
+
 ### Fixed
 - macOS/Linux: device code fallback when browser authentication is unavailable (#309)
 - Linux: MSAL fallback when PowerShell `Connect-MgGraph` fails in non-TTY environments (#309)

src/Microsoft.Agents.A365.DevTools.Cli/Commands/PublishCommand.cs

@@ -60,18 +60,13 @@ private static string GetProjectDirectory(Agent365Config config, ILogger logger)
     public static Command CreateCommand(
         ILogger<PublishCommand> logger,
         IConfigService configService,
-        AgentBlueprintService agentBlueprintService,
         ManifestTemplateService manifestTemplateService)
     {
         var command = new Command("publish", "Update manifest.json IDs and create a manifest package for upload to the Microsoft 365 Admin Center");
 
         var dryRunOption = new Option<bool>("--dry-run", "Show changes without writing file or calling APIs");
-        var verboseOption = new Option<bool>(
-            ["--verbose", "-v"],
-            description: "Enable verbose logging");
 
         command.AddOption(dryRunOption);
-        command.AddOption(verboseOption);
 
         command.SetHandler(async (System.CommandLine.Invocation.InvocationContext context) =>
         {
@@ -217,25 +212,12 @@ public static Command CreateCommand(
                     try { File.Delete(zipPath); } catch { /* ignore */ }
                 }
 
-                // Identify files to include in zip; agenticUserTemplateManifest.json is explicitly listed
-                // to ensure it is always included regardless of other files present in the directory
-                var expectedFiles = new List<string>();
+                // Collect all known manifest files that exist; order is deterministic
                 string[] candidateNames = ["manifest.json", "agenticUserTemplateManifest.json", "color.png", "outline.png", "logo.png", "icon.png"];
-                foreach (var name in candidateNames)
-                {
-                    var p = Path.Combine(manifestDir, name);
-                    if (File.Exists(p)) expectedFiles.Add(p);
-                    if (expectedFiles.Count == 4) break;
-                }
-                // If still fewer than 4, add any other files to reach 4 (non recursive)
-                if (expectedFiles.Count < 4)
-                {
-                    foreach (var f in Directory.EnumerateFiles(manifestDir).Where(f => !expectedFiles.Contains(f)))
-                    {
-                        expectedFiles.Add(f);
-                        if (expectedFiles.Count == 4) break;
-                    }
-                }
+                var expectedFiles = candidateNames
+                    .Select(name => Path.Combine(manifestDir, name))
+                    .Where(File.Exists)
+                    .ToList();
 
                 if (expectedFiles.Count == 0)
                 {

src/Microsoft.Agents.A365.DevTools.Cli/Program.cs

@@ -125,7 +125,7 @@ static async Task<int> Main(string[] args)
             rootCommand.AddCommand(ConfigCommand.CreateCommand(configLogger, wizardService: wizardService, clientAppValidator: clientAppValidator));
             rootCommand.AddCommand(QueryEntraCommand.CreateCommand(queryEntraLogger, configService, executor, graphApiService, agentBlueprintService));
             rootCommand.AddCommand(CleanupCommand.CreateCommand(cleanupLogger, configService, botConfigurator, executor, agentBlueprintService, confirmationProvider, federatedCredentialService));
-            rootCommand.AddCommand(PublishCommand.CreateCommand(publishLogger, configService, agentBlueprintService, manifestTemplateService));
+            rootCommand.AddCommand(PublishCommand.CreateCommand(publishLogger, configService, manifestTemplateService));
 
             // Wrap all command handlers with exception handling
             // Build with middleware for global exception handling

src/Tests/Microsoft.Agents.A365.DevTools.Cli.Tests/Commands/PublishCommandTests.cs

@@ -28,7 +28,6 @@ public class PublishCommandTests : IDisposable
 {
     private readonly ILogger<PublishCommand> _logger;
     private readonly IConfigService _configService;
-    private readonly AgentBlueprintService _blueprintService;
     private readonly ManifestTemplateService _manifestTemplateService;
     private readonly TextReader _originalConsoleIn = Console.In;
 
@@ -37,13 +36,6 @@ public PublishCommandTests()
         _logger = Substitute.For<ILogger<PublishCommand>>();
         _configService = Substitute.For<IConfigService>();
 
-        var graphApiService = Substitute.ForPartsOf<GraphApiService>();
-
-        // AgentBlueprintService needs (ILogger, GraphApiService)
-        _blueprintService = Substitute.ForPartsOf<AgentBlueprintService>(
-            Substitute.For<ILogger<AgentBlueprintService>>(),
-            graphApiService);
-
         // ManifestTemplateService needs only ILogger
         _manifestTemplateService = Substitute.ForPartsOf<ManifestTemplateService>(
             Substitute.For<ILogger<ManifestTemplateService>>());
@@ -71,7 +63,6 @@ public async Task PublishCommand_WithMissingBlueprintId_ShouldReturnExitCode1()
         var command = PublishCommand.CreateCommand(
             _logger,
             _configService,
-            _blueprintService,
             _manifestTemplateService);
 
         var root = new RootCommand();
@@ -120,7 +111,6 @@ public async Task PublishCommand_WithDryRun_ShouldReturnExitCode0()
             var command = PublishCommand.CreateCommand(
                 _logger,
                 _configService,
-                _blueprintService,
                 _manifestTemplateService);
 
             var root = new RootCommand();
@@ -173,13 +163,9 @@ public async Task PublishCommand_WithValidConfig_CreatesZipAndReturnsExitCode0()
             };
             _configService.LoadAsync().Returns(config);
 
-            // Redirect stdin so interactive prompts auto-answer
-            Console.SetIn(new StringReader("n\n\n"));
-
             var command = PublishCommand.CreateCommand(
                 _logger,
                 _configService,
-                _blueprintService,
                 _manifestTemplateService);
 
             var root = new RootCommand();
@@ -211,7 +197,6 @@ public async Task PublishCommand_WithException_ShouldReturnExitCode1()
         var command = PublishCommand.CreateCommand(
             _logger,
             _configService,
-            _blueprintService,
             _manifestTemplateService);
 
         var root = new RootCommand();