Add ability to pass Element itself to targetModal, not only 'id' of element

[4esnog]

Hello!

I am using shadow DOM, and if my modal is hidden inside it, document.getElementById('id-of-shadowed-element') can't select my modal.

I think, it would be handy to have the ability to pass not only id of element, but the element itself in options.targetModal.

Example:

const el = document.querySelector('my-component');
MicroModal.show(el);

[crtl]

Is this still on the radar?

[Raidri]

I push this because I need that feature too for my web components. Is there maybe any new informations?

[ghosh]

In an effort to keep this library lightweight and simple, have decided not to implement this feature. If there is a rising demand for this, am open to consider this again.

Thanks for your patience and understanding guys.

[pbek]

Being able to pass an element as modal would also make this great library work inside of web-components.

Otherwise you'll just get a

Uncaught TypeError: Cannot read property 'setAttribute' of null
    at Modal.showModal (micromodal.es.js:138)

I guess a simple this.modal = typeof targetModal === "string" ? document.getElementById(targetModal) : targetModal would already solve this issue.

[pbek]

@ghosh, I can confirm that changing this one line (https://github.com/ghosh/Micromodal/pull/351/files) allows the library to be used in web components.

[gstvribs]

any updates on this issue?

[obbap1]

please any updates on this ?

[ronilaukkarinen]

Bumping this as well. Not a big change.

[benCoomes]

Another bump, if this library doesn't support shadow dom then I can't use it for the project I am working on. Which is a shame, because it is forward-looking with no dependencies and es6 module support.

[pbek]

Just as a reminder, I have my PR #351 running in production since July 2020 without any issues in our web components.

[pbek]

Any news or considerations on this, @ghosh?

[dkniffin]

I've taken over maintenance of micromodal, and I just merged PR #351. I'll be pushing it out in v0.6.0

[dkniffin]

v0.6.0 is published! 🚀 Let me know if anyone has any issues with it.