-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Paragraph tags stripped from post text #86
Comments
Might this work as a solution for providing both types: "content": [{
"html":"<p>Tuneresque</p><p><img src=\"https://getindiekit.github.io/sandbox/media/photos/2020/08/30/8u53c.jpg\" width=\"600\" height=\"839\" alt=\"Dramatic sunset over Brighton’s West Pier\" style=\"height: auto;\" class=\"sunlit_image\" /></p>",
"value":"Tuneresque\n\n"
}] i.e. |
This issue is about how Sunlit processes text from the timeline API, so not directly related to Micropub or publishing. |
Shall I file a separate bug for this then? |
Sure, feel free to file it. I don't think it's clear how best to handle this, because passing separate Markdown-only text (without any HTML tags) will lose some data since Markdown image references can't have width/height/class. So I'm leaning to not changing this for now until there's more feedback from other Micropub implementations. We always recommend that people enable Markdown processing for anything posted from Micro.blog or Sunlit. |
Moving this out to 3.2 because it isn't a simple/easy fix. The reason we strip the tags in the first place is that the html renderer in iOS labels adds a ridiculous amount of whitespace to the bottom of the view. |
This isn't going to make the cut for 3.2 mostly because I'm not sure exactly how this should be solved. To be honest, I'm not sure it's actually a bug or more of a preference. We're never going to keep all html formatting in the Sunlit feed simply because that's not how it was designed to work. It was a conscious decision to strip the |
Sunlit does some processing on the HTML and (I think) in the process strips out some
<p>
tags that are important parts of the formatting. I don't think we should change this for 3.0 because it risks breaking other things, but maybe shortly after.The text was updated successfully, but these errors were encountered: