fill does not work in plotHistogram

[TuomasBorman]

miaViz/R/plotHistogram.R

Line 302 in 678c690

fill = "grey35", alpha = 0.4, scales = "fixed",

fill parameter does not work, i.e., it does not control the fill color.

This line is incorrect:

miaViz/R/plotHistogram.R

Line 317 in 678c690

fill = if(!is.null(attributes(df)[["fill.by"]]))

If fill.by is not specified, fill should not be applied inside mapping. Instead, the line should be something like this:

fill = if(!is.null(attributes(df)[["fill.by"]])) .data[[attributes(df)[["fill.by"]]]]

(i.e. NULL if fill.by is not specified)

and this line

miaViz/R/plotHistogram.R

Line 324 in 678c690

p <- p + geom_histogram(

should be something like this

fill = if(is.null(attributes(df)[["fill.by"]])) fill

(i.e., fill if fill.by is not specified)

[TuomasBorman]

Check also plotBarplot()