Skip to content

Commit 0ff4e60

Browse files
committed
Bump MMCore patch version for unloadLibrary()
Only bumping the patch version because the unloadLibrary() changes can be considered a bug fix: - Previously, we labeled the function "experimental, don't use" and it did not work in practice. It is unlikely that any existing code calling this function was correct to begin with. - Now we throw an explicit error for library adapters (an improvement) or correctly unregister a mock device adapter (bugfix).
1 parent 3ea6646 commit 0ff4e60

1 file changed

Lines changed: 9 additions & 2 deletions

File tree

‎MMCore/MMCore.cpp‎

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ namespace notif = mmcore::internal::notification;
108108
* (Keep the 3 numbers on one line to make it easier to look at diffs when
109109
* merging/rebasing.)
110110
*/
111-
const int MMCore_versionMajor = 12, MMCore_versionMinor = 5, MMCore_versionPatch = 0;
111+
const int MMCore_versionMajor = 12, MMCore_versionMinor = 5, MMCore_versionPatch = 1;
112112

113113

114114
///////////////////////////////////////////////////////////////////////////////
@@ -1228,9 +1228,16 @@ std::string CMMCore::getDeviceLibrary(const char* label) MMCORE_LEGACY_THROW(CMM
12281228
}
12291229

12301230
/**
1231-
* Forcefully unload a library. Experimental. Don't use.
1231+
* Unload a device adapter.
1232+
*
1233+
* We do not currently have support for unloading regular device adapter
1234+
* libraries.
12321235
*
12331236
* Only mock device adapters can be unloaded.
1237+
*
1238+
* Any devices from the adapter will be unloaded first. Do not call this
1239+
* function when devices from other adapters (e.g. Utilities) may depend on
1240+
* them.
12341241
*/
12351242
void CMMCore::unloadLibrary(const char* moduleName) MMCORE_LEGACY_THROW(CMMError)
12361243
{

0 commit comments

Comments
 (0)